From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: PATCH] iio: Fix some documentation warnings
Date: Wed, 9 Aug 2017 14:35:16 +0100 [thread overview]
Message-ID: <20170809143516.70912657@archlinux> (raw)
In-Reply-To: <20170730161442.0fc96691@lwn.net>
On Sun, 30 Jul 2017 16:14:42 -0600
Jonathan Corbet <corbet@lwn.net> wrote:
> The kerneldoc description for the trig_readonly field of struct iio_dev
> lacked a colon, leading to this doc build warning:
>
> ./include/linux/iio/iio.h:603: warning: No description found for parameter 'trig_readonly'
>
> A similar issue for iio_trigger_set_immutable() in trigger.h yielded:
>
> ./include/linux/iio/trigger.h:151: warning: No description found for parameter 'indio_dev'
> ./include/linux/iio/trigger.h:151: warning: No description found for parameter 'trig'
>
> Fix the formatting and silence the warnings.
>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> include/linux/iio/iio.h | 2 +-
> include/linux/iio/trigger.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index d68bec297a45..c380daa40c0e 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -535,7 +535,7 @@ struct iio_buffer_setup_ops {
> * @scan_timestamp: [INTERN] set if any buffers have requested timestamp
> * @scan_index_timestamp:[INTERN] cache of the index to the timestamp
> * @trig: [INTERN] current device trigger (buffer modes)
> - * @trig_readonly [INTERN] mark the current trigger immutable
> + * @trig_readonly: [INTERN] mark the current trigger immutable
> * @pollfunc: [DRIVER] function run on trigger being received
> * @pollfunc_event: [DRIVER] function run on events trigger being received
> * @channels: [DRIVER] channel specification structure table
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index ea08302f2d7b..7142d8d6e470 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -144,8 +144,8 @@ void devm_iio_trigger_unregister(struct device *dev,
> /**
> * iio_trigger_set_immutable() - set an immutable trigger on destination
> *
> - * @indio_dev - IIO device structure containing the device
> - * @trig - trigger to assign to device
> + * @indio_dev: IIO device structure containing the device
> + * @trig: trigger to assign to device
> *
> **/
> int iio_trigger_set_immutable(struct iio_dev *indio_dev, struct iio_trigger *trig);
prev parent reply other threads:[~2017-08-09 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 22:14 PATCH] iio: Fix some documentation warnings Jonathan Corbet
2017-08-09 13:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809143516.70912657@archlinux \
--to=jic23@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox