From: Jonathan Cameron <jic23@kernel.org>
To: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
daniel.baluta@gmail.com, amsfield22@gmail.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: ccs811: Add ACPI support
Date: Wed, 9 Aug 2017 15:25:00 +0100 [thread overview]
Message-ID: <20170809152500.4ae6fadd@archlinux> (raw)
In-Reply-To: <1501674036-24605-1-git-send-email-narcisaanamaria12@gmail.com>
On Wed, 2 Aug 2017 14:40:36 +0300
Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com> wrote:
> Add ACPI ID to enable ACPI support.
>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> Cc: Alison Schofield <amsfield22@gmail.com>
> Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
> ---
> This patch depends on "iio: chemical: ccs811: Add triggered buffer support"
>
> Note: The ACPI ID is not yet registered at
> http://www.uefi.org/PNP_ACPI_Registry. This vendor doesn't have a
> registered ID yet.
Sorry, until it is registered then we can't take support for it.
ACPI bindings are often entirely random so who knows what the right one
will be.
Jonathan
>
> drivers/iio/chemical/ccs811.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index 8dbb5ed..8a4160e 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -18,6 +18,7 @@
> * 4. Read error register and put the information in logs
> */
>
> +#include <linux/acpi.h>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> #include <linux/iio/iio.h>
> @@ -324,9 +325,16 @@ static int ccs811_remove(struct i2c_client *client)
> };
> MODULE_DEVICE_TABLE(i2c, ccs811_id);
>
> +static const struct acpi_device_id ccs811_acpi_match[] = {
> + {"CCS0811", 0},
> + { },
> +};
> +MODULE_DEVICE_TABLE(acpi, ccs811_acpi_match);
> +
> static struct i2c_driver ccs811_driver = {
> .driver = {
> .name = "ccs811",
> + .acpi_match_table = ACPI_PTR(ccs811_acpi_match),
> },
> .probe = ccs811_probe,
> .remove = ccs811_remove,
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-08-09 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:40 [PATCH] iio: chemical: ccs811: Add ACPI support Narcisa Ana Maria Vasile
2017-08-09 14:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809152500.4ae6fadd@archlinux \
--to=jic23@kernel.org \
--cc=amsfield22@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=narcisaanamaria12@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).