* [PATCH v3 00/13] Support more devices on rockchip rv1108
@ 2017-08-11 3:36 Andy Yan
2017-08-11 3:46 ` [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan
2017-08-11 3:46 ` [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
0 siblings, 2 replies; 6+ messages in thread
From: Andy Yan @ 2017-08-11 3:36 UTC (permalink / raw)
To: heiko
Cc: robh+dt, linux-pwm, linux-i2c, linux-rockchip, linux-iio,
devicetree, wsa, linux-arm-kernel, broonie, linux-kernel,
linux-spi, Andy Yan
This series try to support i2c/spi/pwm/saradc/pmic/watchdog
on rockchip rv1108 soc.
As the clk tree part has been taken from Elaine's series, so
this part will be not included in my series from this version.
This version has no more changes, except the pwm dt-bindings
followed by Rob's suggestion, and the Acked-by from Rob of other
dt-bindings.
Changes in v3:
- remove the clk tree part
- make the compatible string be: "rockchip,rv1108-pwm", "rockchip,rk3288-pwm"
for rv1108 pwm
Changes in v2:
- add compatible string "rockchip,rv1108-pwm"
- add compatible string "rockchip,rv1108-saradc"
Andy Yan (13):
dt-bindings: i2c: rk3x: add support for rv1108
i2c: rk3x: add support for rv1108
ARM: dts: rockchip: add i2c dt node for rv1108
spi: rockchip: add compatible string for rv1108 spi
ARM: dts: rockchip: add spi dt node for rv1108
dt-bindings: pwm: add description for rv1108 pwm
ARM: dts: rockchip: add pwm dt node for rv1108
ARM: dts: rockchip: add watchdog dt node for rv1108
dt-bindings: adc: add description for rv1108 saradc
ARM: dts: rockchip: add saradc support for rv1108
ARM: dts: rockchip: add pwm backlight for rv1108 evb
ARM: dts: rockchip: add pmic rk805 dt node for rv1108 evb
ARM: dts: rockchip: add accelerometer bma250e dt node for rv1108 evb
Documentation/devicetree/bindings/i2c/i2c-rk3x.txt | 1 +
.../bindings/iio/adc/rockchip-saradc.txt | 1 +
.../devicetree/bindings/pwm/pwm-rockchip.txt | 3 +-
.../devicetree/bindings/spi/spi-rockchip.txt | 1 +
arch/arm/boot/dts/rv1108-evb.dts | 158 +++++++++++++
arch/arm/boot/dts/rv1108.dtsi | 249 +++++++++++++++++++++
drivers/i2c/busses/i2c-rk3x.c | 9 +
drivers/spi/spi-rockchip.c | 1 +
8 files changed, 422 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc
2017-08-11 3:36 [PATCH v3 00/13] Support more devices on rockchip rv1108 Andy Yan
@ 2017-08-11 3:46 ` Andy Yan
2017-08-12 12:39 ` Jonathan Cameron
2017-08-11 3:46 ` [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
1 sibling, 1 reply; 6+ messages in thread
From: Andy Yan @ 2017-08-11 3:46 UTC (permalink / raw)
To: heiko
Cc: robh+dt, devicetree, linux-iio, linux-kernel, linux-arm-kernel,
Andy Yan
Add device tree bindings document for saradc on
rockchip rv1108 soc.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v3: None
Changes in v2: None
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
index e0a9b9d..c2c50b5 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
@@ -6,6 +6,7 @@ Required properties:
- "rockchip,rk3066-tsadc": for rk3036
- "rockchip,rk3328-saradc", "rockchip,rk3399-saradc": for rk3328
- "rockchip,rk3399-saradc": for rk3399
+ - "rockchip,rv1108-saradc", "rockchip,rk3399-saradc": for rv1108
- reg: physical base address of the controller and length of memory mapped
region.
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc
2017-08-11 3:46 ` [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan
@ 2017-08-12 12:39 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-08-12 12:39 UTC (permalink / raw)
To: Andy Yan
Cc: heiko, robh+dt, devicetree, linux-iio, linux-kernel,
linux-arm-kernel
On Fri, 11 Aug 2017 11:46:20 +0800
Andy Yan <andy.yan@rock-chips.com> wrote:
> Add device tree bindings document for saradc on
> rockchip rv1108 soc.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>
I've already applied. This please drop it from the next version of the
series.
Jonathan
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> index e0a9b9d..c2c50b5 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> @@ -6,6 +6,7 @@ Required properties:
> - "rockchip,rk3066-tsadc": for rk3036
> - "rockchip,rk3328-saradc", "rockchip,rk3399-saradc": for rk3328
> - "rockchip,rk3399-saradc": for rk3399
> + - "rockchip,rv1108-saradc", "rockchip,rk3399-saradc": for rv1108
>
> - reg: physical base address of the controller and length of memory mapped
> region.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108
2017-08-11 3:36 [PATCH v3 00/13] Support more devices on rockchip rv1108 Andy Yan
2017-08-11 3:46 ` [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan
@ 2017-08-11 3:46 ` Andy Yan
2017-08-13 12:13 ` Heiko Stuebner
1 sibling, 1 reply; 6+ messages in thread
From: Andy Yan @ 2017-08-11 3:46 UTC (permalink / raw)
To: heiko
Cc: robh+dt, devicetree, linux-iio, linux-kernel, linux-arm-kernel,
Andy Yan
Add saradc device tree node for rv1108 soc
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v3: None
Changes in v2:
- add compatible string "rockchip,rv1108-saradc"
arch/arm/boot/dts/rv1108.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 75a0b1e..92b6005 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -275,6 +275,18 @@
status = "disabled";
};
+ adc: adc@1038c000 {
+ compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
+ reg = <0x1038c000 0x100>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+ clock-frequency = <1000000>;
+ clocks = <&cru SCLK_SARADC>, <&cru PCLK_SARADC>;
+ clock-names = "saradc", "apb_pclk";
+ status = "disabled";
+ };
+
i2c0: i2c@20000000 {
compatible = "rockchip,rv1108-i2c";
reg = <0x20000000 0x1000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108
2017-08-11 3:46 ` [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
@ 2017-08-13 12:13 ` Heiko Stuebner
2017-08-14 1:42 ` Andy Yan
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2017-08-13 12:13 UTC (permalink / raw)
To: Andy Yan; +Cc: robh+dt, devicetree, linux-iio, linux-kernel, linux-arm-kernel
Hi Andy,
Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108 soc
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> + adc: adc@1038c000 {
> + compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
> + reg = <0x1038c000 0x100>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
What do you need the io-channel-ranges for?
I.e. according to the documenation it is meant for when the adc is also
a "bus node" and has children that should inherit channels from it.
In all saradc uses so far we only have separate nodes referencing the
adc controller (like adc-keys etc), so this does not look like it is needed?
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108
2017-08-13 12:13 ` Heiko Stuebner
@ 2017-08-14 1:42 ` Andy Yan
0 siblings, 0 replies; 6+ messages in thread
From: Andy Yan @ 2017-08-14 1:42 UTC (permalink / raw)
To: Heiko Stuebner
Cc: robh+dt, devicetree, linux-iio, linux-kernel, linux-arm-kernel,
David Wu
Hi Heiko:
On 2017年08月13日 20:13, Heiko Stuebner wrote:
> Hi Andy,
>
> Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
>> Add saradc device tree node for rv1108 soc
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> + adc: adc@1038c000 {
>> + compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
>> + reg = <0x1038c000 0x100>;
>> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>> + #io-channel-cells = <1>;
>> + io-channel-ranges;
> What do you need the io-channel-ranges for?
> I.e. according to the documenation it is meant for when the adc is also
> a "bus node" and has children that should inherit channels from it.
>
> In all saradc uses so far we only have separate nodes referencing the
> adc controller (like adc-keys etc), so this does not look like it is needed?
Sorry, I just copied it from the downstream dts. After checked with
David, he suggested that we could remove it.
>
>
> Heiko
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-14 1:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 3:36 [PATCH v3 00/13] Support more devices on rockchip rv1108 Andy Yan
2017-08-11 3:46 ` [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan
2017-08-12 12:39 ` Jonathan Cameron
2017-08-11 3:46 ` [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
2017-08-13 12:13 ` Heiko Stuebner
2017-08-14 1:42 ` Andy Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).