From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: linux-iio@vger.kernel.org, gregor.boirie@parrot.com,
denis.ciocca@st.com, lorenzo.bianconi@st.com
Subject: Re: [PATCH 1/2] iio: pressure: st_pressure: fix drdy configuration for LPS22HB and LPS25H
Date: Sat, 12 Aug 2017 13:48:03 +0100 [thread overview]
Message-ID: <20170812134803.71da7c55@archlinux> (raw)
In-Reply-To: <20170811194414.20741-2-lorenzo.bianconi@st.com>
On Fri, 11 Aug 2017 21:44:13 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:
> Remove int2 configuration parameter for LPS22HB and LPS25H since
> these devices export just int1 as data-ready line
>
> Fixes: 931878405b86 (iio:pressure: Add support for LPS25H pressure sensor)
> Fixes: e039e2f5b4da (iio:st_pressure:initial lps22hb sensor support)
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
While this is clearly a fix, as I understand it you would also need to have
some crazy configuration to make this a problem so I am going to take it
for the next merge window rather than quicker.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/pressure/st_pressure_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
> index aa61ec15c139..c84eea73b3ae 100644
> --- a/drivers/iio/pressure/st_pressure_core.c
> +++ b/drivers/iio/pressure/st_pressure_core.c
> @@ -390,7 +390,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
> .drdy_irq = {
> .addr = 0x23,
> .mask_int1 = 0x01,
> - .mask_int2 = 0x10,
> + .mask_int2 = 0x00,
> .addr_ihl = 0x22,
> .mask_ihl = 0x80,
> .addr_od = 0x22,
> @@ -449,7 +449,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
> .drdy_irq = {
> .addr = 0x12,
> .mask_int1 = 0x04,
> - .mask_int2 = 0x08,
> + .mask_int2 = 0x00,
> .addr_ihl = 0x12,
> .mask_ihl = 0x80,
> .addr_od = 0x12,
next prev parent reply other threads:[~2017-08-12 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 19:44 [PATCH 0/2] iio: st_sensors: fix data-ready pin configuration Lorenzo Bianconi
2017-08-11 19:44 ` [PATCH 1/2] iio: pressure: st_pressure: fix drdy configuration for LPS22HB and LPS25H Lorenzo Bianconi
2017-08-12 12:48 ` Jonathan Cameron [this message]
2017-08-11 19:44 ` [PATCH 2/2] iio: accel: st_accel: fix data-ready line configuration Lorenzo Bianconi
2017-08-12 12:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170812134803.71da7c55@archlinux \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=gregor.boirie@parrot.com \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo.bianconi@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).