[PATCH 0/2] iio: st_sensors: fix data-ready pin configuration

[PATCH 0/2] iio: st_sensors: fix data-ready pin configuration

[Lorenzo Bianconi]

Lorenzo Bianconi (2):
  iio: pressure: st_pressure: fix drdy configuration for LPS22HB and
    LPS25H
  iio: accel: st_accel: fix data-ready line configuration

 drivers/iio/accel/st_accel_core.c       | 4 ++--
 drivers/iio/pressure/st_pressure_core.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.14.0

[PATCH 1/2] iio: pressure: st_pressure: fix drdy configuration for LPS22HB and LPS25H

[Lorenzo Bianconi]

Remove int2 configuration parameter for LPS22HB and LPS25H since
these devices export just int1 as data-ready line

Fixes: 931878405b86 (iio:pressure: Add support for LPS25H pressure sensor)
Fixes: e039e2f5b4da (iio:st_pressure:initial lps22hb sensor support)
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
---
 drivers/iio/pressure/st_pressure_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
index aa61ec15c139..c84eea73b3ae 100644
--- a/drivers/iio/pressure/st_pressure_core.c
+++ b/drivers/iio/pressure/st_pressure_core.c
@@ -390,7 +390,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
 		.drdy_irq = {
 			.addr = 0x23,
 			.mask_int1 = 0x01,
-			.mask_int2 = 0x10,
+			.mask_int2 = 0x00,
 			.addr_ihl = 0x22,
 			.mask_ihl = 0x80,
 			.addr_od = 0x22,
@@ -449,7 +449,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
 		.drdy_irq = {
 			.addr = 0x12,
 			.mask_int1 = 0x04,
-			.mask_int2 = 0x08,
+			.mask_int2 = 0x00,
 			.addr_ihl = 0x12,
 			.mask_ihl = 0x80,
 			.addr_od = 0x12,
-- 
2.14.0

[PATCH 2/2] iio: accel: st_accel: fix data-ready line configuration

[Lorenzo Bianconi]

Remove int2 configuration parameter for LIS3DH, LSM303DLHC, LSM330D,
LSM330DL, LSM330DLC, LSM303AGR, LIS2DH12 and LNG2DM since these devices
export just int1 as data-ready line

Fixes: 23cde4d65cc7 (iio: Added platform data to select the DRDY pin)
Fixes: dcdb0a78cab3 (iio: accel: st_accel: add support to lng2dm)
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
---
 drivers/iio/accel/st_accel_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
index 1e0eea110fa9..752856b3a849 100644
--- a/drivers/iio/accel/st_accel_core.c
+++ b/drivers/iio/accel/st_accel_core.c
@@ -161,7 +161,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
 		.drdy_irq = {
 			.addr = 0x22,
 			.mask_int1 = 0x10,
-			.mask_int2 = 0x08,
+			.mask_int2 = 0x00,
 			.addr_ihl = 0x25,
 			.mask_ihl = 0x02,
 			.addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,
@@ -637,7 +637,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
 		.drdy_irq = {
 			.addr = 0x22,
 			.mask_int1 = 0x10,
-			.mask_int2 = 0x08,
+			.mask_int2 = 0x00,
 			.addr_ihl = 0x25,
 			.mask_ihl = 0x02,
 			.addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,
-- 
2.14.0

Re: [PATCH 1/2] iio: pressure: st_pressure: fix drdy configuration for LPS22HB and LPS25H

[Jonathan Cameron]

On Fri, 11 Aug 2017 21:44:13 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:

> Remove int2 configuration parameter for LPS22HB and LPS25H since
> these devices export just int1 as data-ready line
> 
> Fixes: 931878405b86 (iio:pressure: Add support for LPS25H pressure sensor)
> Fixes: e039e2f5b4da (iio:st_pressure:initial lps22hb sensor support)
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
While this is clearly a fix, as I understand it you would also need to have
some crazy configuration to make this a problem so I am going to take it
for the next merge window rather than quicker.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/pressure/st_pressure_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
> index aa61ec15c139..c84eea73b3ae 100644
> --- a/drivers/iio/pressure/st_pressure_core.c
> +++ b/drivers/iio/pressure/st_pressure_core.c
> @@ -390,7 +390,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
>  		.drdy_irq = {
>  			.addr = 0x23,
>  			.mask_int1 = 0x01,
> -			.mask_int2 = 0x10,
> +			.mask_int2 = 0x00,
>  			.addr_ihl = 0x22,
>  			.mask_ihl = 0x80,
>  			.addr_od = 0x22,
> @@ -449,7 +449,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
>  		.drdy_irq = {
>  			.addr = 0x12,
>  			.mask_int1 = 0x04,
> -			.mask_int2 = 0x08,
> +			.mask_int2 = 0x00,
>  			.addr_ihl = 0x12,
>  			.mask_ihl = 0x80,
>  			.addr_od = 0x12,

Re: [PATCH 2/2] iio: accel: st_accel: fix data-ready line configuration

[Jonathan Cameron]

On Fri, 11 Aug 2017 21:44:14 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:

> Remove int2 configuration parameter for LIS3DH, LSM303DLHC, LSM330D,
> LSM330DL, LSM330DLC, LSM303AGR, LIS2DH12 and LNG2DM since these devices
> export just int1 as data-ready line
> 
> Fixes: 23cde4d65cc7 (iio: Added platform data to select the DRDY pin)
> Fixes: dcdb0a78cab3 (iio: accel: st_accel: add support to lng2dm)
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/accel/st_accel_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
> index 1e0eea110fa9..752856b3a849 100644
> --- a/drivers/iio/accel/st_accel_core.c
> +++ b/drivers/iio/accel/st_accel_core.c
> @@ -161,7 +161,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
>  		.drdy_irq = {
>  			.addr = 0x22,
>  			.mask_int1 = 0x10,
> -			.mask_int2 = 0x08,
> +			.mask_int2 = 0x00,
>  			.addr_ihl = 0x25,
>  			.mask_ihl = 0x02,
>  			.addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,
> @@ -637,7 +637,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
>  		.drdy_irq = {
>  			.addr = 0x22,
>  			.mask_int1 = 0x10,
> -			.mask_int2 = 0x08,
> +			.mask_int2 = 0x00,
>  			.addr_ihl = 0x25,
>  			.mask_ihl = 0x02,
>  			.addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,