From: Jonathan Cameron <jic23@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: select triggered buffer for sama5d2 adc
Date: Thu, 17 Aug 2017 15:38:18 +0100 [thread overview]
Message-ID: <20170817153818.7483693a@archlinux> (raw)
In-Reply-To: <20170815144700.2030858-1-arnd@arndb.de>
On Tue, 15 Aug 2017 16:46:31 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> Without the triggered buffer code, we get a link error:
>
> drivers/iio/adc/at91-sama5d2_adc.o: In function `at91_adc_probe':
> at91-sama5d2_adc.c:(.text+0x938): undefined reference to `devm_iio_triggered_buffer_setup'
>
> This adds a Kconfig 'select' statement like other ADC
> drivers have it already.
>
> Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Doh. Shouldn't have missed this one.
Thanks Arnd,
Applied to the togreg branch of iio.git will head for Greg and hence linux-next
in a few days.
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index e4eeebac5297..57625653fcb6 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
> tristate "Atmel AT91 SAMA5D2 ADC"
> depends on ARCH_AT91 || COMPILE_TEST
> depends on HAS_IOMEM
> + select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for Atmel SAMA5D2 ADC which is
> available on SAMA5D2 SoC family.
prev parent reply other threads:[~2017-08-17 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:46 [PATCH] iio: adc: select triggered buffer for sama5d2 adc Arnd Bergmann
2017-08-17 14:38 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817153818.7483693a@archlinux \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=eugen.hristev@microchip.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).