From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:42372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbdHQOi0 (ORCPT ); Thu, 17 Aug 2017 10:38:26 -0400 Date: Thu, 17 Aug 2017 15:38:18 +0100 From: Jonathan Cameron To: Arnd Bergmann Cc: Eugen Hristev , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: select triggered buffer for sama5d2 adc Message-ID: <20170817153818.7483693a@archlinux> In-Reply-To: <20170815144700.2030858-1-arnd@arndb.de> References: <20170815144700.2030858-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, 15 Aug 2017 16:46:31 +0200 Arnd Bergmann wrote: > Without the triggered buffer code, we get a link error: > > drivers/iio/adc/at91-sama5d2_adc.o: In function `at91_adc_probe': > at91-sama5d2_adc.c:(.text+0x938): undefined reference to `devm_iio_triggered_buffer_setup' > > This adds a Kconfig 'select' statement like other ADC > drivers have it already. > > Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support") > Signed-off-by: Arnd Bergmann Doh. Shouldn't have missed this one. Thanks Arnd, Applied to the togreg branch of iio.git will head for Greg and hence linux-next in a few days. Jonathan > --- > drivers/iio/adc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index e4eeebac5297..57625653fcb6 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC > tristate "Atmel AT91 SAMA5D2 ADC" > depends on ARCH_AT91 || COMPILE_TEST > depends on HAS_IOMEM > + select IIO_TRIGGERED_BUFFER > help > Say yes here to build support for Atmel SAMA5D2 ADC which is > available on SAMA5D2 SoC family.