linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: light: apds9300: constify i2c_device_id
Date: Sun, 20 Aug 2017 10:17:02 +0100	[thread overview]
Message-ID: <20170820101702.6cd1242e@archlinux> (raw)
In-Reply-To: <1503168458-17676-3-git-send-email-arvind.yadav.cs@gmail.com>

On Sun, 20 Aug 2017 00:17:37 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by <linux/i2c.h> work with
> const i2c_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.

Thanks,

Jonathan
> ---
>  drivers/iio/light/apds9300.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/apds9300.c b/drivers/iio/light/apds9300.c
> index 649b26f..05eacd1 100644
> --- a/drivers/iio/light/apds9300.c
> +++ b/drivers/iio/light/apds9300.c
> @@ -505,7 +505,7 @@ static SIMPLE_DEV_PM_OPS(apds9300_pm_ops, apds9300_suspend, apds9300_resume);
>  #define APDS9300_PM_OPS NULL
>  #endif
>  
> -static struct i2c_device_id apds9300_id[] = {
> +static const struct i2c_device_id apds9300_id[] = {
>  	{ APDS9300_DRV_NAME, 0 },
>  	{ }
>  };


  reply	other threads:[~2017-08-20  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 18:47 [PATCH 0/3] constify iio i2c_device_id Arvind Yadav
2017-08-19 18:47 ` [PATCH 1/3] iio: accel: bma180: constify i2c_device_id Arvind Yadav
2017-08-20  9:16   ` Jonathan Cameron
2017-08-19 18:47 ` [PATCH 2/3] iio: light: apds9300: " Arvind Yadav
2017-08-20  9:17   ` Jonathan Cameron [this message]
2017-08-19 18:47 ` [PATCH 3/3] iio: light: tsl2583: " Arvind Yadav
2017-08-20  9:17   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820101702.6cd1242e@archlinux \
    --to=jic23@kernel.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).