From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH V2 00/45] IIO: Drop manual assignment of THIS_MODULE
Date: Sun, 3 Sep 2017 12:23:14 +0100 [thread overview]
Message-ID: <20170903122314.324d286f@archlinux> (raw)
In-Reply-To: <20170822221929.0ce921ce@archlinux>
On Tue, 22 Aug 2017 22:19:29 +0100
Jonathan Cameron <jic23@jic23.retrosnub.co.uk> wrote:
> On Mon, 21 Aug 2017 13:38:22 +0100
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
>
> > On Mon, 21 Aug 2017 09:42:01 +0200
> > Lars-Peter Clausen <lars@metafoo.de> wrote:
> >
> > > On 08/20/2017 05:13 PM, Jonathan Cameron wrote:
> > > >
> > > > Hi All,
> > > >
> > > > If anyone has time to look over this set that would be great.
> > > >
> > > > The ancient problem for maintainers, who is the reviewer of last
> > > > resort? Oh me... That doesn't work for my patches :)
> > > >
> > > > No actual rush though - don't mind if these sit until next cycle -
> > > > would just get irritating if they sit until the one after and I have
> > > > to rebase them again...
> > >
> > > Sorry, for the delay. Whole series
> > >
> > > Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> > >
> > > (I didn't actually review each of the individual '-.driver_module =
> > > THIS_MODULE', but I assume coccinelle did the right thing based on the
> > > spatch script).
> >
> > I did a couple of the new ones by hand but they look the same so should
> > be fine!
> >
> > Thanks for review.
> >
> > I'll drop the coccinelle patch I think as the field will have gone away
> > so it won't be possible to set it wrong in future.
> >
> Series minus the coccinelle script applied to the togreg branch of iio.git
> and pushed out as testing.
>
Testing picked up on the fact we have have an iio_dev in
the mux subsystem that I'd forgotten about.
Peter, do you mind if I just pop in an additional patch such as:
diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
index 37ba007f8dca..92495d309193 100644
--- a/drivers/iio/multiplexer/iio-mux.c
+++ b/drivers/iio/multiplexer/iio-mux.c
@@ -173,7 +173,6 @@ static const struct iio_info mux_info = {
.read_raw = mux_read_raw,
.read_avail = mux_read_avail,
.write_raw = mux_write_raw,
- .driver_module = THIS_MODULE,
};
Towards the end of this series?
Thanks,
Jonthan
> Thanks,
>
> Jonathan
>
> > Jonathan
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-03 11:23 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 16:25 [PATCH V2 00/45] IIO: Drop manual assignment of THIS_MODULE Jonathan Cameron
2017-07-23 16:25 ` [PATCH 01/45] iio: Use macro magic to avoid manual assign of driver_module Jonathan Cameron
2017-07-23 16:25 ` [PATCH 02/45] iio: triggers: Use macros to avoid boilerplate assignment of owner Jonathan Cameron
2017-07-23 16:25 ` [PATCH 03/45] iio:trigger: Remove necessity to have a trig->ops structure Jonathan Cameron
2017-07-23 16:25 ` [PATCH 04/45] coccinelle: Add an iio_no_owner semantic patch to drop driver_owner Jonathan Cameron
2017-07-23 16:25 ` [PATCH 05/45] iio:adc: drop assign iio_info.driver_module and iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:25 ` [PATCH 06/45] iio:accel: " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 07/45] iio:amplifiers:ad8366 " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 08/45] iio:chemical: " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 09/45] iio:common: " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 10/45] iio:counter:104-quad-8 drop assign iio_info.driver_module Jonathan Cameron
2017-07-23 16:25 ` [PATCH 11/45] iio:dac: drop assignment of iio_info.driver_module Jonathan Cameron
2017-07-23 16:25 ` [PATCH 12/45] iio:dummy: " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 13/45] iio:frequency: drop assign iio_info.driver_module Jonathan Cameron
2017-07-23 16:25 ` [PATCH 14/45] iio:gyro: drop assign iio_info.driver_module and iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:25 ` [PATCH 15/45] iio:health: " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 16/45] iio:humidity: " Jonathan Cameron
2017-07-23 16:25 ` [PATCH 17/45] iio:imu: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 18/45] iio:light: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 19/45] iio:magnetometer: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 20/45] iio:orientation: drop assign iio_info.driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 21/45] iio:dpot: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 22/45] iio:potentiostat:lmp91000 drop assign iio_info.driver_module and iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 23/45] iio:pressure: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 24/45] iio:proximity: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 25/45] iio:temperature: drop assignment of iio_info.driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 26/45] iio:triggers: drop assign iio_info.driver_module and iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 27/45] staging:iio:accel: drop assignment of iio_info.driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 28/45] staging:iio:adc: drop assign iio_info.driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 29/45] staging:iio:cdc: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 30/45] staging:iio:frequency: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 31/45] staging:iio:gyro:adis16060 " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 32/45] staging:iio:ad5933: " Jonathan Cameron
2017-07-23 16:26 ` [PATCH 33/45] staging:iio:meter: drop assign iio_info.driver_module and iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 34/45] iio:resolver: drop assignment of iio_info.driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 35/45] iio:adc: drop assignment of iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 36/45] staging:iio:light:tsl2x7x drop assignment of driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 37/45] input: tsc2007 - drop the driver_module assignment in iio interface Jonathan Cameron
2017-07-23 16:26 ` [PATCH 38/45] platform/x86: toshiba_acpi: drop assignment of iio_info.driver_module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 39/45] iio: drop iio_info.driver_module and iio_trigger_ops.owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 40/45] iio:adc:max9611: Drop explicit setting of the i2c module owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 41/45] iio:adc:ti-ads8688: Drop manual setting of the driver owner field Jonathan Cameron
2017-07-23 16:26 ` [PATCH 42/45] iio:potentiometer:max5481 drop explicit setting of the owner module Jonathan Cameron
2017-07-23 16:26 ` [PATCH 43/45] iio:potentiometer:max5487: Drop explicit setting of module owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 44/45] staging:iio:docs: drop reference to setting trig_ops->owner Jonathan Cameron
2017-07-23 16:26 ` [PATCH 45/45] staging:iio:docs: drop setting of THIS_MODULE from staging docs Jonathan Cameron
2017-08-20 15:13 ` [PATCH V2 00/45] IIO: Drop manual assignment of THIS_MODULE Jonathan Cameron
2017-08-21 7:42 ` Lars-Peter Clausen
2017-08-21 12:38 ` Jonathan Cameron
2017-08-22 21:19 ` Jonathan Cameron
2017-09-03 11:23 ` Jonathan Cameron [this message]
2017-09-03 13:35 ` Peter Rosin
2017-09-03 17:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170903122314.324d286f@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Jonathan.Cameron@huawei.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).