From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44996 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbdICLXT (ORCPT ); Sun, 3 Sep 2017 07:23:19 -0400 Date: Sun, 3 Sep 2017 12:23:14 +0100 From: Jonathan Cameron To: Jonathan Cameron Cc: Lars-Peter Clausen , , Hartmut Knaack , "Peter Meerwald-Stadler" , Peter Rosin Subject: Re: [PATCH V2 00/45] IIO: Drop manual assignment of THIS_MODULE Message-ID: <20170903122314.324d286f@archlinux> In-Reply-To: <20170822221929.0ce921ce@archlinux> References: <20170723162627.22534-1-Jonathan.Cameron@huawei.com> <20170820161301.1d4570db@archlinux> <20170821133822.0000053f@huawei.com> <20170822221929.0ce921ce@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, 22 Aug 2017 22:19:29 +0100 Jonathan Cameron wrote: > On Mon, 21 Aug 2017 13:38:22 +0100 > Jonathan Cameron wrote: > > > On Mon, 21 Aug 2017 09:42:01 +0200 > > Lars-Peter Clausen wrote: > > > > > On 08/20/2017 05:13 PM, Jonathan Cameron wrote: > > > > > > > > Hi All, > > > > > > > > If anyone has time to look over this set that would be great. > > > > > > > > The ancient problem for maintainers, who is the reviewer of last > > > > resort? Oh me... That doesn't work for my patches :) > > > > > > > > No actual rush though - don't mind if these sit until next cycle - > > > > would just get irritating if they sit until the one after and I have > > > > to rebase them again... > > > > > > Sorry, for the delay. Whole series > > > > > > Reviewed-by: Lars-Peter Clausen > > > > > > (I didn't actually review each of the individual '-.driver_module = > > > THIS_MODULE', but I assume coccinelle did the right thing based on the > > > spatch script). > > > > I did a couple of the new ones by hand but they look the same so should > > be fine! > > > > Thanks for review. > > > > I'll drop the coccinelle patch I think as the field will have gone away > > so it won't be possible to set it wrong in future. > > > Series minus the coccinelle script applied to the togreg branch of iio.git > and pushed out as testing. > Testing picked up on the fact we have have an iio_dev in the mux subsystem that I'd forgotten about. Peter, do you mind if I just pop in an additional patch such as: diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c index 37ba007f8dca..92495d309193 100644 --- a/drivers/iio/multiplexer/iio-mux.c +++ b/drivers/iio/multiplexer/iio-mux.c @@ -173,7 +173,6 @@ static const struct iio_info mux_info = { .read_raw = mux_read_raw, .read_avail = mux_read_avail, .write_raw = mux_write_raw, - .driver_module = THIS_MODULE, }; Towards the end of this series? Thanks, Jonthan > Thanks, > > Jonathan > > > Jonathan > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html