From: Jonathan Cameron <jic23@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 3/7] iio: accel: kxcjk1013: extract report_motion_event() from interrupt handler
Date: Sun, 3 Sep 2017 12:51:31 +0100 [thread overview]
Message-ID: <20170903125131.5338b66c@archlinux> (raw)
In-Reply-To: <a3832939487448c6bc963208150c8d013ba4b8f6.1503352742.git.mirq-linux@rere.qmqm.pl>
On Tue, 22 Aug 2017 00:03:31 +0200
Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
> Extract reporting of motion event direction from interrupt handler,
> as it is not supported by KXTF9.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Looks fine to me. Will pick up once we hear from Srinivas.
Jonathan
> ---
> drivers/iio/accel/kxcjk-1013.c | 126 ++++++++++++++++++++++-------------------
> 1 file changed, 67 insertions(+), 59 deletions(-)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 7828570d87d2..3022bc951dc2 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1032,6 +1032,72 @@ static const struct iio_trigger_ops kxcjk1013_trigger_ops = {
> .owner = THIS_MODULE,
> };
>
> +static void kxcjk1013_report_motion_event(struct iio_dev *indio_dev)
> +{
> + struct kxcjk1013_data *data = iio_priv(indio_dev);
> +
> + int ret = i2c_smbus_read_byte_data(data->client,
> + KXCJK1013_REG_INT_SRC2);
> + if (ret < 0) {
> + dev_err(&data->client->dev, "Error reading reg_int_src2\n");
> + return;
> + }
> +
> + if (ret & KXCJK1013_REG_INT_SRC2_BIT_XN)
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_X,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_FALLING),
> + data->timestamp);
> +
> + if (ret & KXCJK1013_REG_INT_SRC2_BIT_XP)
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_X,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_RISING),
> + data->timestamp);
> +
> + if (ret & KXCJK1013_REG_INT_SRC2_BIT_YN)
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_Y,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_FALLING),
> + data->timestamp);
> +
> + if (ret & KXCJK1013_REG_INT_SRC2_BIT_YP)
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_Y,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_RISING),
> + data->timestamp);
> +
> + if (ret & KXCJK1013_REG_INT_SRC2_BIT_ZN)
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_Z,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_FALLING),
> + data->timestamp);
> +
> + if (ret & KXCJK1013_REG_INT_SRC2_BIT_ZP)
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_Z,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_RISING),
> + data->timestamp);
> +}
> +
> static irqreturn_t kxcjk1013_event_handler(int irq, void *private)
> {
> struct iio_dev *indio_dev = private;
> @@ -1045,65 +1111,7 @@ static irqreturn_t kxcjk1013_event_handler(int irq, void *private)
> }
>
> if (ret & KXCJK1013_REG_INT_SRC1_BIT_WUFS) {
> - ret = i2c_smbus_read_byte_data(data->client,
> - KXCJK1013_REG_INT_SRC2);
> - if (ret < 0) {
> - dev_err(&data->client->dev,
> - "Error reading reg_int_src2\n");
> - goto ack_intr;
> - }
> -
> - if (ret & KXCJK1013_REG_INT_SRC2_BIT_XN)
> - iio_push_event(indio_dev,
> - IIO_MOD_EVENT_CODE(IIO_ACCEL,
> - 0,
> - IIO_MOD_X,
> - IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_FALLING),
> - data->timestamp);
> - if (ret & KXCJK1013_REG_INT_SRC2_BIT_XP)
> - iio_push_event(indio_dev,
> - IIO_MOD_EVENT_CODE(IIO_ACCEL,
> - 0,
> - IIO_MOD_X,
> - IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_RISING),
> - data->timestamp);
> -
> -
> - if (ret & KXCJK1013_REG_INT_SRC2_BIT_YN)
> - iio_push_event(indio_dev,
> - IIO_MOD_EVENT_CODE(IIO_ACCEL,
> - 0,
> - IIO_MOD_Y,
> - IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_FALLING),
> - data->timestamp);
> - if (ret & KXCJK1013_REG_INT_SRC2_BIT_YP)
> - iio_push_event(indio_dev,
> - IIO_MOD_EVENT_CODE(IIO_ACCEL,
> - 0,
> - IIO_MOD_Y,
> - IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_RISING),
> - data->timestamp);
> -
> - if (ret & KXCJK1013_REG_INT_SRC2_BIT_ZN)
> - iio_push_event(indio_dev,
> - IIO_MOD_EVENT_CODE(IIO_ACCEL,
> - 0,
> - IIO_MOD_Z,
> - IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_FALLING),
> - data->timestamp);
> - if (ret & KXCJK1013_REG_INT_SRC2_BIT_ZP)
> - iio_push_event(indio_dev,
> - IIO_MOD_EVENT_CODE(IIO_ACCEL,
> - 0,
> - IIO_MOD_Z,
> - IIO_EV_TYPE_THRESH,
> - IIO_EV_DIR_RISING),
> - data->timestamp);
> + kxcjk1013_report_motion_event(indio_dev);
> }
>
> ack_intr:
next prev parent reply other threads:[~2017-09-03 11:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 22:03 [PATCH v2 0/7] iio: accel: kxcjk1003: support Kionix KXTF9 Michał Mirosław
2017-08-21 22:03 ` [PATCH v2 1/7] iio: accel: kxcjk1003: refactor ODR setting Michał Mirosław
2017-09-03 11:48 ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 2/7] iio: accel: kxcjk1013: fix INT_CTRL/INT_SRC1 bit names Michał Mirosław
2017-09-03 11:50 ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 3/7] iio: accel: kxcjk1013: extract report_motion_event() from interrupt handler Michał Mirosław
2017-09-03 11:51 ` Jonathan Cameron [this message]
2017-08-21 22:03 ` [PATCH v2 4/7] iio: accel: kxcjk1013: rename motion direction bits Michał Mirosław
2017-09-03 11:57 ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 5/7] iio: accel: kxcjk1013: make sysfs/sampling_frequency_avail dynamic Michał Mirosław
2017-09-03 11:58 ` Jonathan Cameron
2017-09-03 12:02 ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 7/7] iio: accel: kxcjk1013: add support for KXTF9 Michał Mirosław
2017-09-03 12:05 ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 6/7] iio: accel: kxcjk1013: make sampling_frequency_avail per-type Michał Mirosław
2017-09-03 11:59 ` Jonathan Cameron
2017-08-21 22:05 ` [PATCH v2 0/7] iio: accel: kxcjk1003: support Kionix KXTF9 Michał Mirosław
2017-09-03 11:43 ` Jonathan Cameron
2017-09-04 21:04 ` Michał Mirosław
2017-09-10 13:32 ` Jonathan Cameron
2017-09-06 15:10 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170903125131.5338b66c@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).