linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 6/7] iio: accel: kxcjk1013: make sampling_frequency_avail per-type
Date: Sun, 3 Sep 2017 12:59:49 +0100	[thread overview]
Message-ID: <20170903125949.71dd98e6@archlinux> (raw)
In-Reply-To: <2bf4d07d81f11add906b449d76efcd04c267d1fd.1503352742.git.mirq-linux@rere.qmqm.pl>

On Tue, 22 Aug 2017 00:03:32 +0200
Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:

> Make sampling_frequency_avail per-type - like sampling_frequency is.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Hmm. This is obviously ABI change.  However, it's pretty obscure so I very
much doubt anyone will notice.  I'd like this 'fixed' anyway so lets
go with it and deal with the fall out should there be any problems.

Jonathan

> ---
>  drivers/iio/accel/kxcjk-1013.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 11bf9afbd248..48b9a97e8a58 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -889,12 +889,13 @@ static ssize_t kxcjk1013_get_samp_freq_avail(struct device *dev,
>  	return sprintf(buf, "%s\n", samp_freq_avail);
>  }
>  
> -static IIO_DEV_ATTR_SAMP_FREQ_AVAIL(kxcjk1013_get_samp_freq_avail);
> +static IIO_DEVICE_ATTR(in_accel_sampling_frequency_available, S_IRUGO,
> +		       kxcjk1013_get_samp_freq_avail, NULL, 0);
>  
>  static IIO_CONST_ATTR(in_accel_scale_available, "0.009582 0.019163 0.038326");
>  
>  static struct attribute *kxcjk1013_attributes[] = {
> -	&iio_dev_attr_sampling_frequency_available.dev_attr.attr,
> +	&iio_dev_attr_in_accel_sampling_frequency_available.dev_attr.attr,
>  	&iio_const_attr_in_accel_scale_available.dev_attr.attr,
>  	NULL,
>  };


  reply	other threads:[~2017-09-03 11:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 22:03 [PATCH v2 0/7] iio: accel: kxcjk1003: support Kionix KXTF9 Michał Mirosław
2017-08-21 22:03 ` [PATCH v2 1/7] iio: accel: kxcjk1003: refactor ODR setting Michał Mirosław
2017-09-03 11:48   ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 2/7] iio: accel: kxcjk1013: fix INT_CTRL/INT_SRC1 bit names Michał Mirosław
2017-09-03 11:50   ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 4/7] iio: accel: kxcjk1013: rename motion direction bits Michał Mirosław
2017-09-03 11:57   ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 3/7] iio: accel: kxcjk1013: extract report_motion_event() from interrupt handler Michał Mirosław
2017-09-03 11:51   ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 6/7] iio: accel: kxcjk1013: make sampling_frequency_avail per-type Michał Mirosław
2017-09-03 11:59   ` Jonathan Cameron [this message]
2017-08-21 22:03 ` [PATCH v2 7/7] iio: accel: kxcjk1013: add support for KXTF9 Michał Mirosław
2017-09-03 12:05   ` Jonathan Cameron
2017-08-21 22:03 ` [PATCH v2 5/7] iio: accel: kxcjk1013: make sysfs/sampling_frequency_avail dynamic Michał Mirosław
2017-09-03 11:58   ` Jonathan Cameron
2017-09-03 12:02     ` Jonathan Cameron
2017-08-21 22:05 ` [PATCH v2 0/7] iio: accel: kxcjk1003: support Kionix KXTF9 Michał Mirosław
2017-09-03 11:43 ` Jonathan Cameron
2017-09-04 21:04   ` Michał Mirosław
2017-09-10 13:32     ` Jonathan Cameron
2017-09-06 15:10   ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170903125949.71dd98e6@archlinux \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).