linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: linux-iio@vger.kernel.org, lorenzo.bianconi@st.com
Subject: Re: [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration
Date: Sun, 24 Sep 2017 16:50:10 +0100	[thread overview]
Message-ID: <20170924165010.03f06740@archlinux> (raw)
In-Reply-To: <20170923191052.14419-2-lorenzo.bianconi@st.com>

On Sat, 23 Sep 2017 21:10:51 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:

> Remove Latched Interrupt configuration since it is enabled by default
> for FIFO watermark interrupt
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>

Not the most detailed explanation ever of a change, but I guess it
suffices (just!)

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index c68cc7c91928..37d6e324ae74 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -56,8 +56,6 @@
>  #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK	BIT(5)
>  #define ST_LSM6DSX_REG_ROUNDING_ADDR		0x16
>  #define ST_LSM6DSX_REG_ROUNDING_MASK		BIT(2)
> -#define ST_LSM6DSX_REG_LIR_ADDR			0x58
> -#define ST_LSM6DSX_REG_LIR_MASK			BIT(0)
>  
>  #define ST_LSM6DSX_REG_ACC_ODR_ADDR		0x10
>  #define ST_LSM6DSX_REG_ACC_ODR_MASK		GENMASK(7, 4)
> @@ -607,12 +605,6 @@ static int st_lsm6dsx_init_device(struct st_lsm6dsx_hw *hw)
>  
>  	msleep(200);
>  
> -	/* latch interrupts */
> -	err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_LIR_ADDR,
> -					 ST_LSM6DSX_REG_LIR_MASK, 1);
> -	if (err < 0)
> -		return err;
> -
>  	/* enable Block Data Update */
>  	err = st_lsm6dsx_write_with_mask(hw, ST_LSM6DSX_REG_BDU_ADDR,
>  					 ST_LSM6DSX_REG_BDU_MASK, 1);


  reply	other threads:[~2017-09-24 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23 19:10 [PATCH 0/2] Remove unnecessary FIFO configurations Lorenzo Bianconi
2017-09-23 19:10 ` [PATCH 1/2] iio: imu: st_lsm6dsx: remove LIR configuration Lorenzo Bianconi
2017-09-24 15:50   ` Jonathan Cameron [this message]
2017-09-25  7:37     ` Lorenzo Bianconi
2017-09-23 19:10 ` [PATCH 2/2] iio: imu: st_lsm6dsx: remove rounding configuration Lorenzo Bianconi
2017-09-24 15:50   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170924165010.03f06740@archlinux \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=lorenzo.bianconi@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).