From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:50992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdKYQoX (ORCPT ); Sat, 25 Nov 2017 11:44:23 -0500 Date: Sat, 25 Nov 2017 16:44:19 +0000 From: Jonathan Cameron To: Colin King Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Lorenzo Bianconi , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: accel: remove redundant pointer pdata Message-ID: <20171125164419.65e41413@archlinux> In-Reply-To: <20171122143211.30651-1-colin.king@canonical.com> References: <20171122143211.30651-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Wed, 22 Nov 2017 14:32:11 +0000 Colin King wrote: > From: Colin Ian King > > Pointer pdata is being assigned but it is never being used, hence > it is redundant and can be removed. Cleans up clang warning: > > drivers/iio/accel/st_accel_core.c:952:3: warning: Value stored to 'pdata' > is never read > > Signed-off-by: Colin Ian King Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > --- > drivers/iio/accel/st_accel_core.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c > index 460aa58e0159..6fe995cf16a6 100644 > --- a/drivers/iio/accel/st_accel_core.c > +++ b/drivers/iio/accel/st_accel_core.c > @@ -920,8 +920,6 @@ static const struct iio_trigger_ops st_accel_trigger_ops = { > int st_accel_common_probe(struct iio_dev *indio_dev) > { > struct st_sensor_data *adata = iio_priv(indio_dev); > - struct st_sensors_platform_data *pdata = > - (struct st_sensors_platform_data *)adata->dev->platform_data; > int irq = adata->get_irq_data_ready(indio_dev); > int err; > > @@ -948,9 +946,6 @@ int st_accel_common_probe(struct iio_dev *indio_dev) > &adata->sensor_settings->fs.fs_avl[0]; > adata->odr = adata->sensor_settings->odr.odr_avl[0].hz; > > - if (!pdata) > - pdata = (struct st_sensors_platform_data *)&default_accel_pdata; > - > err = st_sensors_init_sensor(indio_dev, adata->dev->platform_data); > if (err < 0) > goto st_accel_power_off;