From: Crt Mori <cmo@melexis.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Ian Abbott <abbotti@mev.co.uk>,
Larry Finger <Larry.Finger@lwfinger.net>,
Niklas Soderlund <niklas.soderlund+renesas@ragnatech.se>,
Thomas Gleixner <tglx@linutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Joe Perches <joe@perches.com>, Crt Mori <cmo@melexis.com>
Subject: [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt
Date: Tue, 19 Dec 2017 16:59:08 +0100 [thread overview]
Message-ID: <20171219155908.29528-1-cmo@melexis.com> (raw)
There is no option to perform 64bit integer sqrt on 32bit platform.
Added stronger typed int_sqrt64 enables the 64bit calculations to
be performed on 32bit platforms. Although int_sqrt() is a rough
approximation, the same algorithm is used in int_sqrt64() as good
enough on 32bit platform.
Signed-off-by: Crt Mori <cmo@melexis.com>
---
include/linux/kernel.h | 6 ++++++
lib/int_sqrt.c | 32 ++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 0ad4c3044cf9..f3bebd3a9213 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -459,6 +459,12 @@ extern int kernel_text_address(unsigned long addr);
extern int func_ptr_is_kernel_text(void *ptr);
unsigned long int_sqrt(unsigned long);
+#if BITS_PER_LONG != 64
+#define int_sqrt64 _int_sqrt64
+u32 _int_sqrt64(u64 x);
+#else
+#define int_sqrt64 int_sqrt
+#endif
extern void bust_spinlocks(int yes);
extern int oops_in_progress; /* If set, an oops, panic(), BUG() or die() is in progress */
diff --git a/lib/int_sqrt.c b/lib/int_sqrt.c
index 1ef4cc344977..84c77c934ec3 100644
--- a/lib/int_sqrt.c
+++ b/lib/int_sqrt.c
@@ -36,3 +36,35 @@ unsigned long int_sqrt(unsigned long x)
return y;
}
EXPORT_SYMBOL(int_sqrt);
+
+#if BITS_PER_LONG != 64
+/**
+ *
+ * int_sqrt64 - strongly typed int_sqrt function when minimum 64 bit input
+ * is expected.
+ * @x: 64bit integer of which to calculate the sqrt
+ */
+u32 _int_sqrt64(u64 x)
+{
+ u64 b, m, y = 0;
+
+ if (x <= 1)
+ return x;
+
+ m = 1ULL << (64 - 2);
+ while (m != 0) {
+ b = y + m;
+ y >>= 1;
+
+ if (x >= b) {
+ x -= b;
+ y += m;
+ }
+ m >>= 2;
+ }
+
+ return y;
+}
+EXPORT_SYMBOL(_int_sqrt64);
+#endif
+
--
2.15.0
next reply other threads:[~2017-12-19 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 15:59 Crt Mori [this message]
2017-12-19 16:09 ` [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt Joe Perches
2017-12-19 16:12 ` Peter Zijlstra
2017-12-19 16:14 ` Joe Perches
2017-12-20 9:35 ` Crt Mori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219155908.29528-1-cmo@melexis.com \
--to=cmo@melexis.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abbotti@mev.co.uk \
--cc=akpm@linux-foundation.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox