Re: [PATCH v2] iio/bmp280-core.c: Read calibration data in probe

[Stefan Tatschner <stefan.tatschner@gmail.com>]

On Fri, Dec 29, 2017 at 06:48:55PM +0000, Jonathan Cameron wrote:
> On Tue, 12 Dec 2017 21:35:37 +0100
> Stefan Tatschner <stefan.tatschner@gmail.com> wrote:
> 
> > This patch affects BME280 and BMP280. The readout of the calibration
> > data is moved to the probe function. Each sensor data access triggered
> > reading the full calibration data before this patch. According to the
> > datasheet, Section 4.4.2., the calibration data is stored in non-volatile
> > memory.
> > 
> > Since the calibration data does not change, and cannot be changed by the
> > user, we can reduce bus traffic by reading the calibration data once.
> > Additionally, proper organization of the data types enables removing
> > some odd casts in the compensation formulas.
> > 
> > Signed-off-by: Stefan Tatschner <stefan.tatschner@gmail.com>
> One minor inline. Will fix whilst applying as it's just comment syntax.

Sorry for that. I fired off checkpatch.pl and it didn't complain. I
remember that, for network code or something, it complains about comment
style...

> This was headache inducing to check.  Glad you got to write it ;)
> 
> I've also dropped the entropy add that was in here. It should be proposed
> as a separate patch rather than in here. Particularly as it isn't mentioned
> in the commit message.

If that makes sense for you, I'll send a further patch.

> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.

Thanks!

Stefan