From: Jonathan Cameron <jic23@kernel.org>
To: venkat.prashanth2498@gmail.com
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: [PATCH] imu:adis16480: fix debugfs_simple_attr.cocci warnings
Date: Sun, 7 Jan 2018 17:19:09 +0000 [thread overview]
Message-ID: <20180107171909.226bae6c@archlinux> (raw)
In-Reply-To: <1515317771-4499-1-git-send-email-venkat.prashanth2498@gmail.com>
On Sun, 7 Jan 2018 15:06:11 +0530
venkat.prashanth2498@gmail.com wrote:
> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
>
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Applied, thanks
Jonathan
> ---
> drivers/iio/imu/adis16480.c | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index 7a33d6b..8e9f31f 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -194,7 +194,7 @@ static int adis16480_show_serial_number(void *arg, u64 *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16480_serial_number_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_serial_number_fops,
> adis16480_show_serial_number, NULL, "0x%.4llx\n");
>
> static int adis16480_show_product_id(void *arg, u64 *val)
> @@ -212,7 +212,7 @@ static int adis16480_show_product_id(void *arg, u64 *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16480_product_id_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_product_id_fops,
> adis16480_show_product_id, NULL, "%llu\n");
>
> static int adis16480_show_flash_count(void *arg, u64 *val)
> @@ -230,24 +230,28 @@ static int adis16480_show_flash_count(void *arg, u64 *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16480_flash_count_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_flash_count_fops,
> adis16480_show_flash_count, NULL, "%lld\n");
>
> static int adis16480_debugfs_init(struct iio_dev *indio_dev)
> {
> struct adis16480 *adis16480 = iio_priv(indio_dev);
>
> - debugfs_create_file("firmware_revision", 0400,
> + debugfs_create_file_unsafe("firmware_revision", 0400,
> indio_dev->debugfs_dentry, adis16480,
> &adis16480_firmware_revision_fops);
> - debugfs_create_file("firmware_date", 0400, indio_dev->debugfs_dentry,
> - adis16480, &adis16480_firmware_date_fops);
> - debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry,
> - adis16480, &adis16480_serial_number_fops);
> - debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry,
> - adis16480, &adis16480_product_id_fops);
> - debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry,
> - adis16480, &adis16480_flash_count_fops);
> + debugfs_create_file_unsafe("firmware_date", 0400,
> + indio_dev->debugfs_dentry, adis16480,
> + &adis16480_firmware_date_fops);
> + debugfs_create_file_unsafe("serial_number", 0400,
> + indio_dev->debugfs_dentry, adis16480,
> + &adis16480_serial_number_fops);
> + debugfs_create_file_unsafe("product_id", 0400,
> + indio_dev->debugfs_dentry, adis16480,
> + &adis16480_product_id_fops);
> + debugfs_create_file_unsafe("flash_count", 0400,
> + indio_dev->debugfs_dentry, adis16480,
> + &adis16480_flash_count_fops);
>
> return 0;
> }
> --
> 1.9.1
>
prev parent reply other threads:[~2018-01-07 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 9:36 [PATCH] imu:adis16480: fix debugfs_simple_attr.cocci warnings venkat.prashanth2498
2018-01-07 17:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180107171909.226bae6c@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=venkat.prashanth2498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).