From: Jonathan Cameron <jic23@kernel.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Dmitry Mastykin <mastichi@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Rob Herring <robh@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading
Date: Sun, 14 Jan 2018 10:51:10 +0000 [thread overview]
Message-ID: <20180114105110.14ec8c8f@archlinux> (raw)
In-Reply-To: <CABxcv=kmnithguOYV03KASM2DF09yiRs7FPvnBM3fX=k9+soQw@mail.gmail.com>
On Wed, 10 Jan 2018 12:01:07 +0100
Javier Martinez Canillas <javier@dowhile0.org> wrote:
> Hello Jonathan,
>
> On Mon, Jan 1, 2018 at 10:53 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>
> [snip]
>
> >
> > I may well be missing some subtle detail of course having spent only a few
> > minute looking at this!
> >
>
> Your understanding is correct. This change has nothing to do with
> module autoloading.
>
> The .probe_new callback is only used to avoid requiring an I2C device
> ID table since the old .probe callback has a struct i2c_device_id as a
> parameter and so requires a table even in OF (or ACPI) only drivers.
OK, then let us revisit this patch once we have an answer on your one
fixing the autoprobing more generally. Until we then we don't know
whether we need to add the i2c table in or not whether this suffices.
Jonathan
>
> > Jonathan
>
> Best regards,
> Javier
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-14 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 13:59 [PATCH v2] iio: adc: max9611: fix module auto-loading Dmitry Mastykin
2017-12-29 15:30 ` Andy Shevchenko
2017-12-29 17:54 ` Jonathan Cameron
2017-12-30 12:43 ` Dmitry Mastykin
2018-01-01 9:53 ` Jonathan Cameron
2018-01-03 12:41 ` Dmitry Mastykin
2018-01-06 13:14 ` Jonathan Cameron
2018-01-06 21:37 ` Dmitry Mastykin
2018-01-07 16:08 ` Jonathan Cameron
2018-01-09 11:07 ` Dmitry Mastykin
2018-01-09 20:46 ` Dmitry Mastykin
2018-01-10 3:51 ` Dmitry Mastykin
2018-01-10 11:03 ` Javier Martinez Canillas
2018-01-10 11:01 ` Javier Martinez Canillas
2018-01-14 10:51 ` Jonathan Cameron [this message]
2018-01-15 12:31 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114105110.14ec8c8f@archlinux \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jacopo+renesas@jmondi.org \
--cc=javier@dowhile0.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mastichi@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).