From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:46728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbeANK4k (ORCPT ); Sun, 14 Jan 2018 05:56:40 -0500 Date: Sun, 14 Jan 2018 10:56:36 +0000 From: Jonathan Cameron To: venkat.prashanth2498@gmail.com Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org Subject: Re: [PATCH] imu:adis16400_core: fix debugfs_simple_attr.cocci warnings Message-ID: <20180114105636.49d983c2@archlinux> In-Reply-To: <1515390077-3278-1-git-send-email-venkat.prashanth2498@gmail.com> References: <1515390077-3278-1-git-send-email-venkat.prashanth2498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Mon, 8 Jan 2018 11:11:17 +0530 venkat.prashanth2498@gmail.com wrote: > From: Venkat Prashanth B U > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: Venkat Prashanth B U Patch should have been [PATCH v2] If you don't do that it is far too easy for me to accidentally pick up out of date versions. Anyhow, applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > Change Log v1:- > - Fixed indentation issue. > - changed the subject line appropriately. > --- > drivers/iio/imu/adis16400_core.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c > index 46a5690..b199c73 100644 > --- a/drivers/iio/imu/adis16400_core.c > +++ b/drivers/iio/imu/adis16400_core.c > @@ -85,7 +85,7 @@ static int adis16400_show_product_id(void *arg, u64 *val) > > return 0; > } > -DEFINE_SIMPLE_ATTRIBUTE(adis16400_product_id_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(adis16400_product_id_fops, > adis16400_show_product_id, NULL, "%lld\n"); > > static int adis16400_show_flash_count(void *arg, u64 *val) > @@ -102,7 +102,7 @@ static int adis16400_show_flash_count(void *arg, u64 *val) > > return 0; > } > -DEFINE_SIMPLE_ATTRIBUTE(adis16400_flash_count_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(adis16400_flash_count_fops, > adis16400_show_flash_count, NULL, "%lld\n"); > > static int adis16400_debugfs_init(struct iio_dev *indio_dev) > @@ -110,15 +110,16 @@ static int adis16400_debugfs_init(struct iio_dev *indio_dev) > struct adis16400_state *st = iio_priv(indio_dev); > > if (st->variant->flags & ADIS16400_HAS_SERIAL_NUMBER) > - debugfs_create_file("serial_number", 0400, > + debugfs_create_file_unsafe("serial_number", 0400, > indio_dev->debugfs_dentry, st, > &adis16400_serial_number_fops); > if (st->variant->flags & ADIS16400_HAS_PROD_ID) > - debugfs_create_file("product_id", 0400, > + debugfs_create_file_unsafe("product_id", 0400, > indio_dev->debugfs_dentry, st, > &adis16400_product_id_fops); > - debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry, > - st, &adis16400_flash_count_fops); > + debugfs_create_file_unsafe("flash_count", 0400, > + indio_dev->debugfs_dentry, st, > + &adis16400_flash_count_fops); > > return 0; > } > -- > 1.9.1 > :wq >