linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	<linux-iio@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH] IIO: ADC: stm32-dfsdm: fix static check warning
Date: Mon, 15 Jan 2018 11:32:55 +0000	[thread overview]
Message-ID: <20180115113255.000003ae@huawei.com> (raw)
In-Reply-To: <1516006826-16230-1-git-send-email-arnaud.pouliquen@st.com>

On Mon, 15 Jan 2018 10:00:26 +0100
Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote:

> iio_priv does not return an error pointer, so check is not valid.
> Patch suppresses it.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

If it doesn't make it into Mark's tree pre merge window I'll pick it
up after rc1.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/stm32-dfsdm-adc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index f79a90f..5c67236 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1099,10 +1099,6 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
>  	}
>  
>  	adc = iio_priv(iio);
> -	if (IS_ERR(adc)) {
> -		dev_err(dev, "%s: Failed to allocate ADC\n", __func__);
> -		return PTR_ERR(adc);
> -	}
>  	adc->dfsdm = dev_get_drvdata(dev->parent);
>  
>  	iio->dev.parent = dev;

      reply	other threads:[~2018-01-15 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15  9:00 [PATCH] IIO: ADC: stm32-dfsdm: fix static check warning Arnaud Pouliquen
2018-01-15 11:32 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115113255.000003ae@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alexandre.torgue@st.com \
    --cc=arnaud.pouliquen@st.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).