Re: [PATCH] adc:cpcap-adc: Fix IRQ flags for using threaded handler

[Tony Lindgren <tony@atomide.com>]

Hi,

* Jonathan Cameron <jic23@kernel.org> [180114 12:28]:
> On Thu, 11 Jan 2018 12:41:00 +0530
> + CC: Tony as the author of the driver.
> 
> venkat.prashanth2498@gmail.com wrote:
> 
> > From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> > 
> > Mark the request with ONESHOT using IRQF_ONESHOT.
> > 
> > Semantic patch information:
> > threaded IRQs without a primary handler need to be
> > requested with IRQF_ONESHOT, otherwise the request
> > will fail.
> > So pass the IRQF_ONESHOT flag in this case.
> > 
> > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> > 
> > Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> 
> This looks right but it is rather odd as this should have broken a long
> time ago now when the irq core started getting fussy about this...
> 
> Back in 2012
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1c6c69525b
> 
> Given driver is from 2017 I'm rather surprised...

I think this is now automatically set as the controller
flags don't have IRQCHIP_ONESHOT_SAFE set?

That being said, adding the IRQF_ONESHOT does not hurt either
so no objections to adding that if still considered valid.

But at least the patch description needs to be updated
though, things have been working just fine :)

Regards,

Tony