* [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined
@ 2018-02-01 20:49 Andreas Klinger
2018-02-04 11:21 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Klinger @ 2018-02-01 20:49 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, linux-iio, linux-kernel
Functions for triggered buffer support are needed by this module.
If they are not defined accidentally by another driver, there's an error
thrown out while linking.
Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
drivers/iio/proximity/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig
index fcb1c4ba5e41..f726f9427602 100644
--- a/drivers/iio/proximity/Kconfig
+++ b/drivers/iio/proximity/Kconfig
@@ -68,6 +68,8 @@ config SX9500
config SRF08
tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
+ select IIO_BUFFER
+ select IIO_TRIGGERED_BUFFER
depends on I2C
help
Say Y here to build a driver for Devantech SRF02/SRF08/SRF10
--
2.1.4
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined
2018-02-01 20:49 [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined Andreas Klinger
@ 2018-02-04 11:21 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-02-04 11:21 UTC (permalink / raw)
To: Andreas Klinger; +Cc: knaack.h, lars, pmeerw, linux-iio, linux-kernel
On Thu, 1 Feb 2018 21:49:24 +0100
Andreas Klinger <ak@it-klinger.de> wrote:
> Functions for triggered buffer support are needed by this module.
> If they are not defined accidentally by another driver, there's an error
> thrown out while linking.
>
> Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
Applied to the fixes-togreg-post-rc1 branch of iio.git with a fixes
tag added. Please always track down the patch that introduced the
problem and add a fixes tag. It makes it much easier for the stable
trees to know when to apply the patch or not.
I put the patch that introduced the triggered support in the first
place as that seemed likely to be the place that the issue was
introduced.
Thanks,
Jonathan
> ---
> drivers/iio/proximity/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig
> index fcb1c4ba5e41..f726f9427602 100644
> --- a/drivers/iio/proximity/Kconfig
> +++ b/drivers/iio/proximity/Kconfig
> @@ -68,6 +68,8 @@ config SX9500
>
> config SRF08
> tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
> + select IIO_BUFFER
> + select IIO_TRIGGERED_BUFFER
> depends on I2C
> help
> Say Y here to build a driver for Devantech SRF02/SRF08/SRF10
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-04 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-01 20:49 [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined Andreas Klinger
2018-02-04 11:21 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).