From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <jic23@kernel.org>, <knaack.h@gmx.de>, <lars@metafoo.de>,
<pmeerw@pmeerw.net>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: [PATCH 4/5] iio: accel: bcm150: Remove handling for regmap raw_read_max
Date: Thu, 15 Feb 2018 17:52:19 +0000 [thread overview]
Message-ID: <20180215175220.2691-4-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20180215175220.2691-1-ckeepax@opensource.cirrus.com>
The regmap core now handles splitting up transactions according to
max_raw_read, so this code is no longer required in client drivers.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/iio/accel/bmc150-accel-core.c | 23 +++--------------------
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index 870f92ef61c2..3d2e6b501bf9 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -838,29 +838,12 @@ static int bmc150_accel_fifo_transfer(struct bmc150_accel_data *data,
int sample_length = 3 * 2;
int ret;
int total_length = samples * sample_length;
- int i;
- size_t step = regmap_get_raw_read_max(data->regmap);
-
- if (!step || step > total_length)
- step = total_length;
- else if (step < total_length)
- step = sample_length;
-
- /*
- * Seems we have a bus with size limitation so we have to execute
- * multiple reads
- */
- for (i = 0; i < total_length; i += step) {
- ret = regmap_raw_read(data->regmap, BMC150_ACCEL_REG_FIFO_DATA,
- &buffer[i], step);
- if (ret)
- break;
- }
+ ret = regmap_raw_read(data->regmap, BMC150_ACCEL_REG_FIFO_DATA,
+ buffer, total_length);
if (ret)
dev_err(dev,
- "Error transferring data from fifo in single steps of %zu\n",
- step);
+ "Error transferring data from fifo: %d\n", ret);
return ret;
}
--
2.11.0
next prev parent reply other threads:[~2018-02-15 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 17:52 [PATCH 1/5] regmap: Move the handling for max_raw_read into regmap_raw_read Charles Keepax
2018-02-15 17:52 ` [PATCH 2/5] regmap: Tidy up regmap_raw_read chunking code Charles Keepax
2018-02-16 12:05 ` Applied "regmap: Tidy up regmap_raw_read chunking code" to the regmap tree Mark Brown
2018-02-15 17:52 ` [PATCH 3/5] regmap: Use _regmap_read in regmap_bulk_read Charles Keepax
2018-02-16 12:05 ` Applied "regmap: Use _regmap_read in regmap_bulk_read" to the regmap tree Mark Brown
2018-02-15 17:52 ` Charles Keepax [this message]
2018-02-17 14:09 ` [PATCH 4/5] iio: accel: bcm150: Remove handling for regmap raw_read_max Jonathan Cameron
2018-02-19 11:42 ` Charles Keepax
2018-02-15 17:52 ` [PATCH 5/5] regmap: Remove regmap_get_raw_read_max Charles Keepax
2018-02-16 12:03 ` Mark Brown
2018-02-19 11:43 ` Charles Keepax
2018-02-16 12:05 ` Applied "regmap: Move the handling for max_raw_read into regmap_raw_read" to the regmap tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215175220.2691-4-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).