From: Jonathan Cameron <jic23@kernel.org>
To: rodrigosiqueira <rodrigosiqueiramelo@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
daniel.baluta@nxp.com, linux-iio@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio:pressure:ms5611: Fix coding style in probe function
Date: Sat, 17 Feb 2018 12:42:29 +0000 [thread overview]
Message-ID: <20180217124229.18d335fe@archlinux> (raw)
In-Reply-To: <20180216194441.nep5zbb5sjf53cj6@smtp.gmail.com>
On Fri, 16 Feb 2018 17:44:41 -0200
rodrigosiqueira <rodrigosiqueiramelo@gmail.com> wrote:
> This patch fixes the checkpatch.pl warning and error:
>
> iio/pressure/ms5611.h:66: ERROR: code indent should use tabs where possible
> iio/pressure/ms5611.h:66: WARNING: please, no spaces at the start of a line
> iio/pressure/ms5611.h:66: ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks Daniel for your quick feedback on this.
Thanks,
Jonathan
> ---
> Changes in v2:
> - Make the commit message more clearer.
>
> drivers/iio/pressure/ms5611.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/ms5611.h b/drivers/iio/pressure/ms5611.h
> index ccda63c5b3c3..ead9e9f85894 100644
> --- a/drivers/iio/pressure/ms5611.h
> +++ b/drivers/iio/pressure/ms5611.h
> @@ -63,7 +63,7 @@ struct ms5611_state {
> };
>
> int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
> - const char* name, int type);
> + const char *name, int type);
> int ms5611_remove(struct iio_dev *indio_dev);
>
> #endif /* _MS5611_H */
prev parent reply other threads:[~2018-02-17 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 19:44 [PATCH v2] iio:pressure:ms5611: Fix coding style in probe function rodrigosiqueira
2018-02-17 12:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217124229.18d335fe@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).