From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:50554 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbeBTMhi (ORCPT ); Tue, 20 Feb 2018 07:37:38 -0500 Date: Tue, 20 Feb 2018 15:36:52 +0300 From: Dan Carpenter To: Rodrigo Siqueira Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Peter Meerwald-Stadler , Hartmut Knaack , daniel.baluta@nxp.com, Jonathan Cameron Subject: Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments Message-ID: <20180220123652.evmvebkdimfcofl3@mwanda> References: <20180219162832.qbkogggfzwbgsqlt@smtp.gmail.com> <20180220072442.2oxvhwequzzc3gz2@mwanda> <20180220122156.s25laa4wgcf3hxuz@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180220122156.s25laa4wgcf3hxuz@smtp.gmail.com> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, Feb 20, 2018 at 09:21:56AM -0300, Rodrigo Siqueira wrote: > On 02/20, Dan Carpenter wrote: > > > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote: > > ^^^^^^^^^^^^^^^ > > This looks good, but you need to fix your from email header. > > Thanks for the review, and the feedback related to the email header. > I already fixed it. Is it necessary to resend the patch? > I don't know? Sometimes mainainters will cleanup patches themselves... Probably it's simplest to just resend, yes. regards, dan carpenter