From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen
Date: Wed, 21 Feb 2018 13:15:12 -0300 [thread overview]
Message-ID: <20180221161512.bxpqtjwg4sxjphki@smtp.gmail.com> (raw)
In-Reply-To: <CAEnQRZAhZ=PR+X3=HYRQKkTHUnczWcsv4945piCrwK31PbuXGg@mail.gmail.com>
On 02/21, Daniel Baluta wrote:
> On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira
> <rodrigosiqueiramelo@gmail.com> wrote:
> > This patch fixes the following checkpatch.pl warnings:
> >
> > drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
> > align the * on each line
> > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> > 'S_IWUSR' are not preferred. Consider using octal permissions '0200'...
> > drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line
> > after function/struct/union/enum declarations
>
> You are trying to fix 3 things in one patch here. Please don't do that.
>
> One patch per change please.
Even for a simple comment line fix?
> thanks,
> Daniel.
prev parent reply other threads:[~2018-02-21 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 14:05 [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen Rodrigo Siqueira
2018-02-21 16:04 ` Daniel Baluta
2018-02-21 16:15 ` Rodrigo Siqueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221161512.bxpqtjwg4sxjphki@smtp.gmail.com \
--to=rodrigosiqueiramelo@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).