From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:49008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbeBXNaN (ORCPT ); Sat, 24 Feb 2018 08:30:13 -0500 Date: Sat, 24 Feb 2018 13:30:09 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: Re: [PATCH v1] iio: accel: bmc150: Remove redundant __func__ in dev_dbg() Message-ID: <20180224133009.2f0c61df@archlinux> In-Reply-To: <20180222185858.28714-1-andriy.shevchenko@linux.intel.com> References: <20180222185858.28714-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Thu, 22 Feb 2018 20:58:58 +0200 Andy Shevchenko wrote: > Dynamic debug has a run time knob to enable function name printing. > Remove this from dev_dbg() calls. > > Furthermore, functional tracing when enabled can show what function is > called, therefore remove empty dev_dbg() calls. > > Signed-off-by: Andy Shevchenko Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/bmc150-accel-core.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c > index 870f92ef61c2..208f2d9f0e8a 100644 > --- a/drivers/iio/accel/bmc150-accel-core.c > +++ b/drivers/iio/accel/bmc150-accel-core.c > @@ -336,8 +336,7 @@ static int bmc150_accel_update_slope(struct bmc150_accel_data *data) > return ret; > } > > - dev_dbg(dev, "%s: %x %x\n", __func__, data->slope_thres, > - data->slope_dur); > + dev_dbg(dev, "%x %x\n", data->slope_thres, data->slope_dur); > > return ret; > } > @@ -1716,7 +1715,6 @@ static int bmc150_accel_runtime_suspend(struct device *dev) > struct bmc150_accel_data *data = iio_priv(indio_dev); > int ret; > > - dev_dbg(dev, __func__); > ret = bmc150_accel_set_mode(data, BMC150_ACCEL_SLEEP_MODE_SUSPEND, 0); > if (ret < 0) > return -EAGAIN; > @@ -1731,8 +1729,6 @@ static int bmc150_accel_runtime_resume(struct device *dev) > int ret; > int sleep_val; > > - dev_dbg(dev, __func__); > - > ret = bmc150_accel_set_mode(data, BMC150_ACCEL_SLEEP_MODE_NORMAL, 0); > if (ret < 0) > return ret;