From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:52112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964895AbeCGUHf (ORCPT ); Wed, 7 Mar 2018 15:07:35 -0500 Date: Wed, 7 Mar 2018 20:07:30 +0000 From: Jonathan Cameron To: Rodrigo Siqueira Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Greg Kroah-Hartman , daniel.baluta@nxp.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR Message-ID: <20180307200730.08ed3c2f@archlinux> In-Reply-To: <3af0e5a795059a8418cf08ff29f05f8d5e00da9b.1520382753.git.rodrigosiqueiramelo@gmail.com> References: <3af0e5a795059a8418cf08ff29f05f8d5e00da9b.1520382753.git.rodrigosiqueiramelo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, 6 Mar 2018 21:43:47 -0300 Rodrigo Siqueira wrote: > The macro IIO_DEV_ATTR_CH_OFF is a wrapper for IIO_DEVICE_ATTR, with a > tiny change in the name definition. This extra macro does not improve > the readability and also creates some checkpatch errors. > > This patch fixes the checkpatch.pl errors: > > staging/iio/meter/ade7753.c:391: ERROR: Use 4 digit octal (0777) not > decimal permissions > staging/iio/meter/ade7753.c:395: ERROR: Use 4 digit octal (0777) not > decimal permissions > staging/iio/meter/ade7759.c:331: ERROR: Use 4 digit octal (0777) not > decimal permissions > staging/iio/meter/ade7759.c:335: ERROR: Use 4 digit octal (0777) not > decimal permissions > > Signed-off-by: Rodrigo Siqueira Hmm. I wondered a bit about this one. It's a correct patch in of itself but the interface in question doesn't even vaguely conform to any of defined IIO ABI. Anyhow, it's still and improvement so I'll take it. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. I also added the removal of the header define which is no longer used. Please note, following discussions with Michael, I am going to send an email announcing an intent to drop these meter drivers next cycle unless someone can provide testing for any attempt to move them out of staging. I'm still taking patches on the basis that 'might' happen - but I wouldn't focus on these until we have some certainty on whether they will be around long term! Jonathan > --- > drivers/staging/iio/meter/ade7753.c | 18 ++++++++++-------- > drivers/staging/iio/meter/ade7759.c | 18 ++++++++++-------- > 2 files changed, 20 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c > index c44eb577dc35..275e8dfff836 100644 > --- a/drivers/staging/iio/meter/ade7753.c > +++ b/drivers/staging/iio/meter/ade7753.c > @@ -388,14 +388,16 @@ static IIO_DEV_ATTR_VPERIOD(0444, > ade7753_read_16bit, > NULL, > ADE7753_PERIOD); > -static IIO_DEV_ATTR_CH_OFF(1, 0644, > - ade7753_read_8bit, > - ade7753_write_8bit, > - ADE7753_CH1OS); > -static IIO_DEV_ATTR_CH_OFF(2, 0644, > - ade7753_read_8bit, > - ade7753_write_8bit, > - ADE7753_CH2OS); > + > +static IIO_DEVICE_ATTR(choff_1, 0644, > + ade7753_read_8bit, > + ade7753_write_8bit, > + ADE7753_CH1OS); > + > +static IIO_DEVICE_ATTR(choff_2, 0644, > + ade7753_read_8bit, > + ade7753_write_8bit, > + ADE7753_CH2OS); > > static int ade7753_set_irq(struct device *dev, bool enable) > { > diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c > index 1decb2b8afab..c078b770fa53 100644 > --- a/drivers/staging/iio/meter/ade7759.c > +++ b/drivers/staging/iio/meter/ade7759.c > @@ -328,14 +328,16 @@ static IIO_DEV_ATTR_ACTIVE_POWER_GAIN(0644, > ade7759_read_16bit, > ade7759_write_16bit, > ADE7759_APGAIN); > -static IIO_DEV_ATTR_CH_OFF(1, 0644, > - ade7759_read_8bit, > - ade7759_write_8bit, > - ADE7759_CH1OS); > -static IIO_DEV_ATTR_CH_OFF(2, 0644, > - ade7759_read_8bit, > - ade7759_write_8bit, > - ADE7759_CH2OS); > + > +static IIO_DEVICE_ATTR(choff_1, 0644, > + ade7759_read_8bit, > + ade7759_write_8bit, > + ADE7759_CH1OS); > + > +static IIO_DEVICE_ATTR(choff_2, 0644, > + ade7759_read_8bit, > + ade7759_write_8bit, > + ADE7759_CH2OS); > > static int ade7759_set_irq(struct device *dev, bool enable) > {