* [PATCH] Staging: iio: adt7316: Move symbol export to definition
@ 2018-03-08 9:47 David Veenstra
2018-03-10 15:19 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: David Veenstra @ 2018-03-08 9:47 UTC (permalink / raw)
To: lars; +Cc: linux-iio
This patch clears the following checkpatch.pl warning:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
+EXPORT_SYMBOL_GPL(adt7316_pm_ops);
Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
---
drivers/staging/iio/addac/adt7316.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 2d33632c00e8..3f22d1088713 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -2079,9 +2079,8 @@ static int adt7316_enable(struct device *dev)
return _adt7316_store_enabled(chip, 1);
}
-
-SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
EXPORT_SYMBOL_GPL(adt7316_pm_ops);
+SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
#endif
static const struct iio_info adt7316_info = {
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: iio: adt7316: Move symbol export to definition
2018-03-08 9:47 [PATCH] Staging: iio: adt7316: Move symbol export to definition David Veenstra
@ 2018-03-10 15:19 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-03-10 15:19 UTC (permalink / raw)
To: David Veenstra; +Cc: lars, linux-iio
On Thu, 8 Mar 2018 10:47:29 +0100
David Veenstra <davidjulianveenstra@gmail.com> wrote:
> This patch clears the following checkpatch.pl warning:
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> +EXPORT_SYMBOL_GPL(adt7316_pm_ops);
>
> Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 2d33632c00e8..3f22d1088713 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -2079,9 +2079,8 @@ static int adt7316_enable(struct device *dev)
>
> return _adt7316_store_enabled(chip, 1);
> }
> -
> -SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
> EXPORT_SYMBOL_GPL(adt7316_pm_ops);
> +SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
> #endif
>
> static const struct iio_info adt7316_info = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-10 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-08 9:47 [PATCH] Staging: iio: adt7316: Move symbol export to definition David Veenstra
2018-03-10 15:19 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox