From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:35718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbeCJQln (ORCPT ); Sat, 10 Mar 2018 11:41:43 -0500 Date: Sat, 10 Mar 2018 16:41:37 +0000 From: Jonathan Cameron To: Rodrigo Siqueira Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Graff Yang , daniel.baluta@nxp.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging:iio:ad2s1210: Remove end of line with '[' Message-ID: <20180310164137.6ca243aa@archlinux> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Fri, 9 Mar 2018 20:45:50 -0300 Rodrigo Siqueira wrote: > This patch fixes the checkpatch.pl check: > > iio/resolver/ad2s1210.c:202: CHECK: Lines should not end with a '[' > > Signed-off-by: Rodrigo Siqueira Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index f8baab061eba..0cdcd71e285b 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -165,9 +165,10 @@ int ad2s1210_update_frequency_control_word(struct ad2s1210_state *st) > > static unsigned char ad2s1210_read_resolution_pin(struct ad2s1210_state *st) > { > - return ad2s1210_resolution_value[ > - (gpio_get_value(st->pdata->res[0]) << 1) | > - gpio_get_value(st->pdata->res[1])]; > + int resolution = (gpio_get_value(st->pdata->res[0]) << 1) | > + gpio_get_value(st->pdata->res[1]); > + > + return ad2s1210_resolution_value[resolution]; > } > > static const int ad2s1210_res_pins[4][2] = {