From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: John Syne <john3909@gmail.com>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com>,
daniel.baluta@nxp.com
Subject: Re: [PATCH v2 8/8] staging:iio:ade7854: Remove read_reg_* duplications
Date: Sun, 18 Mar 2018 10:05:47 +0000 [thread overview]
Message-ID: <20180318100547.11d52bd4@archlinux> (raw)
In-Reply-To: <dce9761d7477287e8b4d043695c064c97859ec58.1521239766.git.rodrigosiqueiramelo@gmail.com>
On Fri, 16 Mar 2018 19:50:29 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> The original code had a read function per data size; after updates, all
> read functions tasks were centralized in a single function, but the old
> signature was kept to maintain the module working without problems. This
> patch removes a set of duplications associated with read_reg_*, and
> update the areas that calling the old interface by the new one. During
> the update for use a single function, some errors handlings were updated
> based on the John Syne patches.
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Signed-off-by: John Syne <john3909@gmail.com>
The meaning of John's signed-off-by here needs clarifying..
Also fix up the common on error handling as I believe you now do that in
an earlier patch.
Thanks and looking forward to v3. This is a nice little bit of cleanup.
These weird devices with variable register sizes are always somewhat of
a pain to deal with.
Jonathan
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 37 +------------------------------
> drivers/staging/iio/meter/ade7854-spi.c | 39 ++-------------------------------
> drivers/staging/iio/meter/ade7854.c | 18 +++++++--------
> drivers/staging/iio/meter/ade7854.h | 7 +++---
> 4 files changed, 15 insertions(+), 86 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 20db8eedb84a..162c171a8851 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -110,38 +110,6 @@ static int ade7854_i2c_read_reg(struct device *dev,
> return ret;
> }
>
> -static int ade7854_i2c_read_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 *val)
> -{
> - return ade7854_i2c_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_8_BITS);
> -}
> -
> -static int ade7854_i2c_read_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 *val)
> -{
> - return ade7854_i2c_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_16_BITS);
> -}
> -
> -static int ade7854_i2c_read_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> -{
> - return ade7854_i2c_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_24_BITS);
> -}
> -
> -static int ade7854_i2c_read_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> -{
> - return ade7854_i2c_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_32_BITS);
> -}
> -
> static int ade7854_i2c_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> @@ -153,10 +121,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,
> return -ENOMEM;
> st = iio_priv(indio_dev);
> i2c_set_clientdata(client, indio_dev);
> - st->read_reg_8 = ade7854_i2c_read_reg_8;
> - st->read_reg_16 = ade7854_i2c_read_reg_16;
> - st->read_reg_24 = ade7854_i2c_read_reg_24;
> - st->read_reg_32 = ade7854_i2c_read_reg_32;
> + st->read_reg = ade7854_i2c_read_reg;
> st->write_reg = ade7854_i2c_write_reg;
> st->i2c = client;
> st->irq = client->irq;
> diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> index 964d6c6e76d1..66b8a8767a26 100644
> --- a/drivers/staging/iio/meter/ade7854-spi.c
> +++ b/drivers/staging/iio/meter/ade7854-spi.c
> @@ -94,7 +94,7 @@ static int ade7854_spi_read_reg(struct device *dev,
> st->tx[2] = reg_address & 0xFF;
>
> ret = spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
> - if (ret) {
> + if (ret < 0) {
> dev_err(&st->spi->dev, "problem when reading register 0x%02X",
> reg_address);
> goto unlock;
> @@ -120,38 +120,6 @@ static int ade7854_spi_read_reg(struct device *dev,
> return ret;
> }
>
> -static int ade7854_spi_read_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 *val)
> -{
> - return ade7854_spi_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_8_BITS);
> -}
> -
> -static int ade7854_spi_read_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 *val)
> -{
> - return ade7854_spi_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_16_BITS);
> -}
> -
> -static int ade7854_spi_read_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> -{
> - return ade7854_spi_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_24_BITS);
> -}
> -
> -static int ade7854_spi_read_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> -{
> - return ade7854_spi_read_reg(dev, reg_address, (u32 *)val,
> - DATA_SIZE_32_BITS);
> -}
> -
> static int ade7854_spi_probe(struct spi_device *spi)
> {
> struct ade7854_state *st;
> @@ -162,10 +130,7 @@ static int ade7854_spi_probe(struct spi_device *spi)
> return -ENOMEM;
> st = iio_priv(indio_dev);
> spi_set_drvdata(spi, indio_dev);
> - st->read_reg_8 = ade7854_spi_read_reg_8;
> - st->read_reg_16 = ade7854_spi_read_reg_16;
> - st->read_reg_24 = ade7854_spi_read_reg_24;
> - st->read_reg_32 = ade7854_spi_read_reg_32;
> + st->read_reg = ade7854_spi_read_reg;
> st->write_reg = ade7854_spi_write_reg;
> st->irq = spi->irq;
> st->spi = spi;
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index 4aa7c6ce0016..09fd8c067738 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -27,12 +27,12 @@ static ssize_t ade7854_read_8bit(struct device *dev,
> char *buf)
> {
> int ret;
> - u8 val = 0;
> + u32 val = 0;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>
> - ret = st->read_reg_8(dev, this_attr->address, &val);
> + ret = st->read_reg(dev, this_attr->address, &val, DATA_SIZE_8_BITS);
> if (ret < 0)
> return ret;
>
> @@ -44,12 +44,12 @@ static ssize_t ade7854_read_16bit(struct device *dev,
> char *buf)
> {
> int ret;
> - u16 val = 0;
> + u32 val = 0;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>
> - ret = st->read_reg_16(dev, this_attr->address, &val);
> + ret = st->read_reg(dev, this_attr->address, &val, DATA_SIZE_16_BITS);
> if (ret < 0)
> return ret;
>
> @@ -66,7 +66,7 @@ static ssize_t ade7854_read_24bit(struct device *dev,
> struct ade7854_state *st = iio_priv(indio_dev);
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>
> - ret = st->read_reg_24(dev, this_attr->address, &val);
> + ret = st->read_reg(dev, this_attr->address, &val, DATA_SIZE_24_BITS);
> if (ret < 0)
> return ret;
>
> @@ -83,7 +83,7 @@ static ssize_t ade7854_read_32bit(struct device *dev,
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
>
> - ret = st->read_reg_32(dev, this_attr->address, &val);
> + ret = st->read_reg(dev, this_attr->address, &val, DATA_SIZE_32_BITS);
> if (ret < 0)
> return ret;
>
> @@ -178,9 +178,9 @@ static int ade7854_reset(struct device *dev)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> - u16 val;
> + u32 val;
>
> - st->read_reg_16(dev, ADE7854_CONFIG, &val);
> + st->read_reg(dev, ADE7854_CONFIG, &val, DATA_SIZE_16_BITS);
> val |= BIT(7); /* Software Chip Reset */
>
> return st->write_reg(dev, ADE7854_CONFIG, val, DATA_SIZE_16_BITS);
> @@ -415,7 +415,7 @@ static int ade7854_set_irq(struct device *dev, bool enable)
> int ret;
> u32 irqen;
>
> - ret = st->read_reg_32(dev, ADE7854_MASK0, &irqen);
> + ret = st->read_reg(dev, ADE7854_MASK0, &irqen, DATA_SIZE_32_BITS);
> if (ret < 0)
> return ret;
>
> diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h
> index aa29faf7c91f..78584f01d052 100644
> --- a/drivers/staging/iio/meter/ade7854.h
> +++ b/drivers/staging/iio/meter/ade7854.h
> @@ -153,6 +153,7 @@ enum data_size {
> /**
> * struct ade7854_state - device instance specific data
> * @spi: actual spi_device
> + * @read_reg Wrapper function for I2C and SPI read
> * @write_reg Wrapper function for I2C and SPI write
> * @indio_dev: industrial I/O device structure
> * @buf_lock: mutex to protect tx and rx
> @@ -162,10 +163,8 @@ enum data_size {
> struct ade7854_state {
> struct spi_device *spi;
> struct i2c_client *i2c;
> - int (*read_reg_8)(struct device *dev, u16 reg_address, u8 *val);
> - int (*read_reg_16)(struct device *dev, u16 reg_address, u16 *val);
> - int (*read_reg_24)(struct device *dev, u16 reg_address, u32 *val);
> - int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val);
> + int (*read_reg)(struct device *dev, u16 reg_address, u32 *val,
> + int type);
> int (*write_reg)(struct device *dev, u16 reg_address, u32 val,
> int type);
> int irq;
prev parent reply other threads:[~2018-03-18 10:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 22:48 [PATCH v2 0/8] staging:iio:ade7854: Cleanup on I2C/SPI code Rodrigo Siqueira
2018-03-16 22:48 ` [PATCH v2 1/8] staging:iio:ade7854: Fix error handling on read/write Rodrigo Siqueira
2018-03-18 9:45 ` Jonathan Cameron
2018-03-20 1:53 ` Rodrigo Siqueira
2018-03-16 22:48 ` [PATCH v2 2/8] staging:iio:ade7854: Fix the wrong number of bits to read Rodrigo Siqueira
2018-03-18 9:48 ` Jonathan Cameron
2018-03-16 22:49 ` [PATCH v2 3/8] staging:iio:ade7854: Rework I2C write function Rodrigo Siqueira
2018-03-18 9:56 ` Jonathan Cameron
2018-03-16 22:49 ` [PATCH v2 4/8] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-18 9:57 ` Jonathan Cameron
2018-03-16 22:49 ` [PATCH v2 5/8] staging:iio:ade7854: Replace many functions for one function Rodrigo Siqueira
2018-03-18 9:58 ` Jonathan Cameron
2018-03-16 22:49 ` [PATCH v2 6/8] staging:iio:ade7854: Rework I2C read function Rodrigo Siqueira
2018-03-18 10:00 ` Jonathan Cameron
2018-03-16 22:50 ` [PATCH v2 7/8] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-16 22:50 ` [PATCH v2 8/8] staging:iio:ade7854: Remove read_reg_* duplications Rodrigo Siqueira
2018-03-18 10:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318100547.11d52bd4@archlinux \
--to=jic23@kernel.org \
--cc=21cnbao@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john3909@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).