From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:57058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbeC3JUo (ORCPT ); Fri, 30 Mar 2018 05:20:44 -0400 Date: Fri, 30 Mar 2018 10:20:39 +0100 From: Jonathan Cameron To: Gwendal Grignou Cc: linux-iio@vger.kernel.org, enric.balletbo@collabora.com Subject: Re: [PATCH v2] iio: cros_ec: Move cros_ec_sensors_core.h in /include Message-ID: <20180330102039.429b7707@archlinux> In-Reply-To: <20180328235349.111656-1-gwendal@chromium.org> References: <20180317200003.595e88d5@archlinux> <20180328235349.111656-1-gwendal@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Wed, 28 Mar 2018 16:53:49 -0700 Gwendal Grignou wrote: > Similar to other common iio frameworks, move cros_ec_sensors_core.h from > drivers/iio/common/cros_ec_sensors/ to include/linux/iio/common. > > Signed-off-by: Gwendal Grignou Hi Gwendal, My previous email wasn't very clear - I applied the original patch with an appropriate fix. There was not need to include the platform_device header - a forward declaration of struct platform_device was less invasive and what I originally went with. Thanks, Jonathan > --- > > Changes in v2: > - Include linux/platform_device.h in cros_ec_sensors_core.h > > drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 3 +-- > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 3 +-- > drivers/iio/light/cros_ec_light_prox.c | 3 +-- > drivers/iio/pressure/cros_ec_baro.c | 3 +-- > .../linux/iio/common}/cros_ec_sensors_core.h | 3 +++ > 5 files changed, 7 insertions(+), 8 deletions(-) > rename {drivers/iio/common/cros_ec_sensors => include/linux/iio/common}/cros_ec_sensors_core.h (98%) > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > index 7d30c59da3e2..8e3f99a8b30c 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -31,8 +32,6 @@ > #include > #include > > -#include "cros_ec_sensors_core.h" > - > #define CROS_EC_SENSORS_MAX_CHANNELS 4 > > /* State data for ec_sensors iio driver. */ > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > index 416cae5ebbd0..ea3268bd92f4 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -27,8 +28,6 @@ > #include > #include > > -#include "cros_ec_sensors_core.h" > - > static char *cros_ec_loc[] = { > [MOTIONSENSE_LOC_BASE] = "base", > [MOTIONSENSE_LOC_LID] = "lid", > diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c > index acfad4aeb27a..15bd105b08f3 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -29,8 +30,6 @@ > #include > #include > > -#include "../common/cros_ec_sensors/cros_ec_sensors_core.h" > - > /* > * We only represent one entry for light or proximity. EC is merging different > * light sensors to return the what the eye would see. For proximity, we > diff --git a/drivers/iio/pressure/cros_ec_baro.c b/drivers/iio/pressure/cros_ec_baro.c > index 4599fde4dd25..87c07af9181f 100644 > --- a/drivers/iio/pressure/cros_ec_baro.c > +++ b/drivers/iio/pressure/cros_ec_baro.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -28,8 +29,6 @@ > #include > #include > > -#include "../common/cros_ec_sensors/cros_ec_sensors_core.h" > - > /* > * One channel for pressure, the other for timestamp. > */ > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h b/include/linux/iio/common/cros_ec_sensors_core.h > similarity index 98% > rename from drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h > rename to include/linux/iio/common/cros_ec_sensors_core.h > index 8bc2ca3c2e2e..e6b6190ba8af 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h > +++ b/include/linux/iio/common/cros_ec_sensors_core.h > @@ -16,7 +16,10 @@ > #ifndef __CROS_EC_SENSORS_CORE_H > #define __CROS_EC_SENSORS_CORE_H > > +#include > #include > +#include > +#include > > enum { > CROS_EC_SENSOR_X,