From: Jonathan Cameron <jic23@kernel.org>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
Michael.Hennerich@analog.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, daniel.baluta@gmail.com
Subject: Re: [PATCH v6 1/6] Staging: iio: adis16209: Indent the field definitions
Date: Fri, 30 Mar 2018 11:39:14 +0100 [thread overview]
Message-ID: <20180330113914.7d9dc309@archlinux> (raw)
In-Reply-To: <508a70d5477067c083408fc81e58023c7e91bc95.1522306893.git.shreeya.patel23498@gmail.com>
On Thu, 29 Mar 2018 14:42:02 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> Have indentation in field definitions to make them
> clearly different from the register addresses.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Note that, given the timing wrt to the current kernel cycle
(merge window will probably open this weekend), this and
everything for the last 2 weeks is now destined to go upstream
in the next cycle.
Thanks,
Jonathan
> ---
>
> Changes in v5
> -Change some macro names and have indentation in the field
> definitions.
>
> Changes in v6
> -Have indentation in the field definitions and do not
> change the names of the macros as the patch for changing
> the names has already been applied.
>
> drivers/staging/iio/accel/adis16209.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index a8453bf..0e6366a 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -71,13 +71,13 @@
> #define ADIS16209_STAT_REG 0x3C
> #define ADIS16209_STAT_ALARM2 BIT(9)
> #define ADIS16209_STAT_ALARM1 BIT(8)
> -#define ADIS16209_STAT_SELFTEST_FAIL_BIT 5
> -#define ADIS16209_STAT_SPI_FAIL_BIT 3
> -#define ADIS16209_STAT_FLASH_UPT_FAIL_BIT 2
> +#define ADIS16209_STAT_SELFTEST_FAIL_BIT 5
> +#define ADIS16209_STAT_SPI_FAIL_BIT 3
> +#define ADIS16209_STAT_FLASH_UPT_FAIL_BIT 2
> /* Power supply above 3.625 V */
> -#define ADIS16209_STAT_POWER_HIGH_BIT 1
> +#define ADIS16209_STAT_POWER_HIGH_BIT 1
> /* Power supply below 3.15 V */
> -#define ADIS16209_STAT_POWER_LOW_BIT 0
> +#define ADIS16209_STAT_POWER_LOW_BIT 0
>
> #define ADIS16209_CMD_REG 0x3E
> #define ADIS16209_CMD_SW_RESET BIT(7)
next prev parent reply other threads:[~2018-03-30 10:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 9:10 [PATCH v6 0/6] adis16209 driver cleanup Shreeya Patel
2018-03-29 9:12 ` [PATCH v6 1/6] Staging: iio: adis16209: Indent the field definitions Shreeya Patel
2018-03-30 10:39 ` Jonathan Cameron [this message]
2018-03-29 9:13 ` [PATCH v6 2/6] Staging: iio: adis16209: Prefer reverse christmas tree ordering Shreeya Patel
2018-03-30 11:32 ` Jonathan Cameron
2018-03-29 9:14 ` [PATCH v6 3/6] Staging: iio: adis16209: Add a blank line after return statements Shreeya Patel
2018-03-30 11:33 ` Jonathan Cameron
2018-03-29 9:19 ` [PATCH v6 4/6] Staging: iio: adis16209: Remove unused headers Shreeya Patel
2018-03-30 11:36 ` Jonathan Cameron
2018-03-29 9:21 ` [PATCH v6 5/6] Staging: iio: adis16209: Use GENMASK Shreeya Patel
2018-03-30 11:40 ` Jonathan Cameron
2018-03-29 9:22 ` [PATCH v6 6/6] Staging: iio: adis16209: Move adis16209 driver out of staging Shreeya Patel
2018-03-30 11:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330113914.7d9dc309@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).