linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	Michael.Hennerich@analog.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, daniel.baluta@gmail.com
Subject: Re: [PATCH v6 2/6] Staging: iio: adis16209: Prefer reverse christmas tree ordering
Date: Fri, 30 Mar 2018 12:32:38 +0100	[thread overview]
Message-ID: <20180330123238.51d9b2a5@archlinux> (raw)
In-Reply-To: <3f021293e6183f6fefb597a9a01b762b73d69bc3.1522306893.git.shreeya.patel23498@gmail.com>

On Thu, 29 Mar 2018 14:43:23 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:

> Prefer reverse christmas tree ordering of declarations to
> improve readability.
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
> 
> Changes in v6
>   -Introduce this new patch in the series.
> 
>  drivers/staging/iio/accel/adis16209.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index 0e6366a..8f4fa6b 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -270,9 +270,9 @@ static const struct adis_data adis16209_data = {
>  
>  static int adis16209_probe(struct spi_device *spi)
>  {
> -	int ret;
> -	struct adis *st;
>  	struct iio_dev *indio_dev;
> +	struct adis *st;
> +	int ret;
>  
>  	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
>  	if (!indio_dev)


  reply	other threads:[~2018-03-30 11:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29  9:10 [PATCH v6 0/6] adis16209 driver cleanup Shreeya Patel
2018-03-29  9:12 ` [PATCH v6 1/6] Staging: iio: adis16209: Indent the field definitions Shreeya Patel
2018-03-30 10:39   ` Jonathan Cameron
2018-03-29  9:13 ` [PATCH v6 2/6] Staging: iio: adis16209: Prefer reverse christmas tree ordering Shreeya Patel
2018-03-30 11:32   ` Jonathan Cameron [this message]
2018-03-29  9:14 ` [PATCH v6 3/6] Staging: iio: adis16209: Add a blank line after return statements Shreeya Patel
2018-03-30 11:33   ` Jonathan Cameron
2018-03-29  9:19 ` [PATCH v6 4/6] Staging: iio: adis16209: Remove unused headers Shreeya Patel
2018-03-30 11:36   ` Jonathan Cameron
2018-03-29  9:21 ` [PATCH v6 5/6] Staging: iio: adis16209: Use GENMASK Shreeya Patel
2018-03-30 11:40   ` Jonathan Cameron
2018-03-29  9:22 ` [PATCH v6 6/6] Staging: iio: adis16209: Move adis16209 driver out of staging Shreeya Patel
2018-03-30 11:48   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180330123238.51d9b2a5@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=daniel.baluta@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=shreeya.patel23498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).