public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: fix FIFO threshold mask for LSM6DSM/LSM6DSL
Date: Sun, 8 Apr 2018 16:49:11 +0100	[thread overview]
Message-ID: <20180408164911.37b09b9a@archlinux> (raw)
In-Reply-To: <20180330184322.5455-1-lorenzo.bianconi@redhat.com>

On Fri, 30 Mar 2018 20:43:22 +0200
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> According to the latest datasheet, LSM6DSM and LSM6DSL imu sensors
> export GENMASK(10, 0) for FIFO threshold mask definition. Despite
> that is not an actual issue since write on fifo_th register is protected
> by max_fifo_size value, fix fifo_th and fifo_diff register definitions
> 
> Fixes: 290a6ce11d93 ("iio: imu: add support to lsm6dsx driver")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 8656d72ef4ee..50d6491df484 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -266,11 +266,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  		.fifo_ops = {
>  			.fifo_th = {
>  				.addr = 0x06,
> -				.mask = GENMASK(11, 0),
> +				.mask = GENMASK(10, 0),
>  			},
>  			.fifo_diff = {
>  				.addr = 0x3a,
> -				.mask = GENMASK(11, 0),
> +				.mask = GENMASK(10, 0),
>  			},
>  			.th_wl = 3, /* 1LSB = 2B */
>  		},


      reply	other threads:[~2018-04-08 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 18:43 [PATCH] iio: imu: st_lsm6dsx: fix FIFO threshold mask for LSM6DSM/LSM6DSL Lorenzo Bianconi
2018-04-08 15:49 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180408164911.37b09b9a@archlinux \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox