From: Javier Arteaga <javier@emutex.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Dan O'Donovan <dan@emutex.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc128s052: add ACPI _HID AANT1280
Date: Sat, 21 Apr 2018 21:46:05 +0100 [thread overview]
Message-ID: <20180421204507.i77d6ov2je7e4ec7@localhost> (raw)
In-Reply-To: <20180421170505.60d7784a@archlinux>
Hi Jonathan,
On Sat, Apr 21, 2018 at 05:05:05PM +0100, Jonathan Cameron wrote:
> This is in principle fine, but I'd like to see it done somewhat more
> explicitly.
>
> 1) Add the adc124s101 and similar families to the driver first. I think
> this is just a case of IDs for all of
> adc124s051 and adc124s101.
>
> 2) Add the ACPI ID as you have done here.
>
> That way we at least reflect clearly that the part is supported rather than
> just in a comment on the ACPI ID.
Will do for v2.
Thank you!
prev parent reply other threads:[~2018-04-21 20:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 13:20 [PATCH 0/2] ACPI match adc128s052 to ADC on UP Squared Javier Arteaga
2018-04-19 13:20 ` [PATCH 1/2] iio: adc128s052: allow driver to be matched using ACPI Javier Arteaga
2018-04-21 15:54 ` Jonathan Cameron
2018-04-21 20:41 ` Javier Arteaga
2018-04-24 17:23 ` Jonathan Cameron
2018-04-24 19:33 ` Javier Arteaga
2018-04-19 13:20 ` [PATCH 2/2] iio: adc128s052: add ACPI _HID AANT1280 Javier Arteaga
2018-04-21 16:05 ` Jonathan Cameron
2018-04-21 20:46 ` Javier Arteaga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421204507.i77d6ov2je7e4ec7@localhost \
--to=javier@emutex.com \
--cc=dan@emutex.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).