From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZgA+=HK=emutex.com=javier@kernel.org>
Date: Sat, 21 Apr 2018 21:46:05 +0100
From: Javier Arteaga <javier@emutex.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Dan O'Donovan <dan@emutex.com>, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc128s052: add ACPI _HID AANT1280
Message-ID: <20180421204507.i77d6ov2je7e4ec7@localhost>
References: <20180419132036.27493-1-javier@emutex.com>
 <20180419132036.27493-3-javier@emutex.com>
 <20180421170505.60d7784a@archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
In-Reply-To: <20180421170505.60d7784a@archlinux>
List-ID: <linux-iio@vger.kernel.org>

Hi Jonathan,

On Sat, Apr 21, 2018 at 05:05:05PM +0100, Jonathan Cameron wrote:
> This is in principle fine, but I'd like to see it done somewhat more
> explicitly.
> 
> 1) Add the adc124s101 and similar families to the driver first. I think
>    this is just a case of IDs for all of
>    adc124s051 and adc124s101.
> 
> 2) Add the ACPI ID as you have done here.
> 
> That way we at least reflect clearly that the part is supported rather than
> just in a comment on the ACPI ID.

Will do for v2.

Thank you!