Re: [PATCH v2 08/11] staging: iio: tsl2x7x: add device ids for code readability

Jonathan Cameron
2018-05-06T18:26:11Z

On Thu, 3 May 2018 22:53:16 -0400
Brian Masney <masneyb@onstation.org> wrote:

> This patch adds the device IDs to the device_channel_config array to
> improve code readability.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
> drivers/staging/iio/light/tsl2x7x.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c
> index e3e37501829f..39de5e60fd33 100644
> --- a/drivers/staging/iio/light/tsl2x7x.c
> +++ b/drivers/staging/iio/light/tsl2x7x.c
> @@ -273,16 +273,16 @@ enum {
> };
>
> static const u8 device_channel_config[] = {
> - ALS,
> - PRX,
> - PRX,
> - ALSPRX,
> - ALSPRX,
> - ALS,
> - PRX2,
> - PRX2,
> - ALSPRX2,
> - ALSPRX2
> + [tsl2571] = ALS,
> + [tsl2671] = PRX,
> + [tmd2671] = PRX,
> + [tsl2771] = ALSPRX,
> + [tmd2771] = ALSPRX,
> + [tsl2572] = ALS,
> + [tsl2672] = PRX2,
> + [tmd2672] = PRX2,
> + [tsl2772] = ALSPRX2,
> + [tmd2772] = ALSPRX2
> };
>
> static int tsl2x7x_read_status(struct tsl2X7X_chip *chip)