From: Jonathan Cameron <jic23@kernel.org>
To: Martin Kelly <mkelly@xevo.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tools: iio: iio_generic_buffer: fix types to match
Date: Sun, 20 May 2018 14:55:24 +0100 [thread overview]
Message-ID: <20180520145524.092a1d5d@archlinux> (raw)
In-Reply-To: <20180518001446.15607-1-mkelly@xevo.com>
On Thu, 17 May 2018 17:14:45 -0700
Martin Kelly <mkelly@xevo.com> wrote:
> Several types are mismatched and causing implicit conversions. Fix them
> up so the types match.
>
> Signed-off-by: Martin Kelly <mkelly@xevo.com>
Whilst I find it hard to care much about these, there might be a possible
bug as a result, so fair enough to clean them up.
Applied to the togreg branch of iio.git and pushed out as testing.
Jonathan
> ---
> tools/iio/iio_generic_buffer.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
> index f0c6f54a8b2f..aa765c11992b 100644
> --- a/tools/iio/iio_generic_buffer.c
> +++ b/tools/iio/iio_generic_buffer.c
> @@ -334,7 +334,10 @@ int main(int argc, char **argv)
> unsigned long timedelay = 1000000;
> unsigned long buf_len = 128;
>
> - int ret, c, i, j, toread;
> + ssize_t i;
> + unsigned long j;
> + unsigned long toread;
> + int ret, c;
> int fp = -1;
>
> int num_channels = 0;
next prev parent reply other threads:[~2018-05-20 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 0:14 [PATCH v2 1/2] tools: iio: iio_generic_buffer: fix types to match Martin Kelly
2018-05-18 0:14 ` [PATCH v2 2/2] tools: iio: iio_generic_buffer: allow continuous looping Martin Kelly
2018-05-20 13:57 ` Jonathan Cameron
2018-05-20 13:55 ` Jonathan Cameron [this message]
2018-05-21 16:14 ` [PATCH v2 1/2] tools: iio: iio_generic_buffer: fix types to match Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520145524.092a1d5d@archlinux \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mkelly@xevo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).