From: Jonathan Cameron <jic23@kernel.org>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
device-drivers-devel@blackfin.uclinux.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adc: ad7606: fix function pointer parameter names missing.
Date: Sun, 10 Jun 2018 14:42:52 +0100 [thread overview]
Message-ID: <20180610144252.31794e13@archlinux> (raw)
In-Reply-To: <20180608221331.116928-1-giulio.benetti@micronovasrl.com>
On Sat, 9 Jun 2018 00:13:31 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> Checkpatch.pl complains about function pointer parameter names missing.
>
> Add parameter names.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7606.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7606.h b/drivers/staging/iio/adc/ad7606.h
> index acaed8d5379c..9716ee9d94a7 100644
> --- a/drivers/staging/iio/adc/ad7606.h
> +++ b/drivers/staging/iio/adc/ad7606.h
> @@ -57,7 +57,7 @@ struct ad7606_state {
>
> struct ad7606_bus_ops {
> /* more methods added in future? */
> - int (*read_block)(struct device *, int, void *);
> + int (*read_block)(struct device *dev, int num, void *data);
> };
>
> int ad7606_probe(struct device *dev, int irq, void __iomem *base_address,
prev parent reply other threads:[~2018-06-10 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 22:13 [PATCH] staging: iio: adc: ad7606: fix function pointer parameter names missing Giulio Benetti
2018-06-10 13:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180610144252.31794e13@archlinux \
--to=jic23@kernel.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=giulio.benetti@micronovasrl.com \
--cc=greg@kroah.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox