* [PATCH] staging: iio: adc: ad7606: fix function pointer parameter names missing.
@ 2018-06-08 22:13 Giulio Benetti
2018-06-10 13:42 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Giulio Benetti @ 2018-06-08 22:13 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: device-drivers-devel, Jonathan Cameron, linux-iio, Giulio Benetti
Checkpatch.pl complains about function pointer parameter names missing.
Add parameter names.
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
drivers/staging/iio/adc/ad7606.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7606.h b/drivers/staging/iio/adc/ad7606.h
index acaed8d5379c..9716ee9d94a7 100644
--- a/drivers/staging/iio/adc/ad7606.h
+++ b/drivers/staging/iio/adc/ad7606.h
@@ -57,7 +57,7 @@ struct ad7606_state {
struct ad7606_bus_ops {
/* more methods added in future? */
- int (*read_block)(struct device *, int, void *);
+ int (*read_block)(struct device *dev, int num, void *data);
};
int ad7606_probe(struct device *dev, int irq, void __iomem *base_address,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: adc: ad7606: fix function pointer parameter names missing.
2018-06-08 22:13 [PATCH] staging: iio: adc: ad7606: fix function pointer parameter names missing Giulio Benetti
@ 2018-06-10 13:42 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-06-10 13:42 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Greg Kroah-Hartman, device-drivers-devel, linux-iio
On Sat, 9 Jun 2018 00:13:31 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> Checkpatch.pl complains about function pointer parameter names missing.
>
> Add parameter names.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7606.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7606.h b/drivers/staging/iio/adc/ad7606.h
> index acaed8d5379c..9716ee9d94a7 100644
> --- a/drivers/staging/iio/adc/ad7606.h
> +++ b/drivers/staging/iio/adc/ad7606.h
> @@ -57,7 +57,7 @@ struct ad7606_state {
>
> struct ad7606_bus_ops {
> /* more methods added in future? */
> - int (*read_block)(struct device *, int, void *);
> + int (*read_block)(struct device *dev, int num, void *data);
> };
>
> int ad7606_probe(struct device *dev, int irq, void __iomem *base_address,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-10 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08 22:13 [PATCH] staging: iio: adc: ad7606: fix function pointer parameter names missing Giulio Benetti
2018-06-10 13:42 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).