From: Dan Carpenter <dan.carpenter@oracle.com>
To: Karim Eshapa <karim.eshapa@gmail.com>
Cc: lars@metafoo.de, devel@driverdev.osuosl.org,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
pmeerw@pmeerw.net, knaack.h@gmx.de, jic23@kernel.org
Subject: Re: [PATCH 4/4] staging:iio:adc:ad7280a: Use GFP_ATOMIC in interrupt handler
Date: Fri, 29 Jun 2018 10:45:33 +0300 [thread overview]
Message-ID: <20180629074532.cbwwjx2lh6cc3f72@mwanda> (raw)
In-Reply-To: <20180628234928.4205-1-karim.eshapa@gmail.com>
On Fri, Jun 29, 2018 at 01:49:28AM +0200, Karim Eshapa wrote:
> Use GFP_ATOMIC rather GFP_KERNEL in interrupt handler,
> as GFP_KERNEL may sleep according to slab allocator.
>
This is a threaded IRQ so it can sleep.
You should always think about the impact of a bug. If this were a bug
it would have showed up in testing right away. Most of my patches are
in error handling and so the impact is zero unless you deliberately try
to inject errors that's why they can go undetected for years.
Also you should always use the Fixes tag to see how the patch was
introduced. I often see bugs where the patch is new and it was
introduced by someone doing major subsystem cleanups and they don't have
the hardware so I know it hasn't been tested. If the patch is a couple
years old and the bug is in the success path which every one tests then
I wonder if I am misreading the code somehow.
regards,
dan carpenter
next prev parent reply other threads:[~2018-06-29 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 23:49 [PATCH 4/4] staging:iio:adc:ad7280a: Use GFP_ATOMIC in interrupt handler Karim Eshapa
2018-06-29 7:45 ` Dan Carpenter [this message]
2018-06-29 10:12 ` karim eshapa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629074532.cbwwjx2lh6cc3f72@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=karim.eshapa@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox