Re: [PATCH v5 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC

Jonathan Cameron
2018-07-07T17:21:09Z

On Thu, 5 Jul 2018 15:18:58 -0600
Rob Herring <robh@kernel.org> wrote:

> On Wed, Jul 04, 2018 at 05:32:53PM +0300, Stefan Popa wrote:
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > ---
> > Changes in v5:
> > - used a dac@0 as a more generic node name instead of ad5758@0.
> > Changes in v4:
> > - Nothing changed, just to follow the patch set version.
> > Changes in v3:
> > - AD5758 can be both a current and voltage output DAC. The
> > decision is made based on the DT and the channel type is set
> > during probe.
> > - range was replaced by range-microvolt and range-microamp
> > - dc-dc-mode, range-microvolt and range-microamp are required
> > properties.
> > - Introduced a slew-time-us property from which slew rate clock
> > and slew rate step are calculated using a best match algorithm.
> > - Added units in the name of the properties.
> > - Offered more explanation for the various modes of operation.
> >
> > Changes in v2:
> > - Nothing changed, just to follow the patch set version.
> >
> > .../devicetree/bindings/iio/dac/ad5758.txt | 73 ++++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 74 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt
>
> Reviewed-by: Rob Herring <robh@kernel.org>

There was a bit of white space weirdness in here and some lines that needed
breaking. I fixed up whilst applying.

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Also feels like I haven't explicitly thanked Rob in a while, so... thanks Rob
for your tireless work on making sure we keep idiocy in device tree bindings
to a minimum!

Jonathan