From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Daniel Baluta <daniel.baluta@gmail.com>
Subject: Re: [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor
Date: Sat, 21 Jul 2018 17:31:31 +0100 [thread overview]
Message-ID: <20180721173131.6be1579f@archlinux> (raw)
In-Reply-To: <20180721153607.GA11127@himanshu-Vostro-3559>
On Sat, 21 Jul 2018 21:06:08 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:
> > Hi Himanshu,
> >
> > This was close to the point where I'd take it and make the few remaining
> > fixes myself. I'm still bothered however by the fact the casts in the
> > various calibration functions are still not all justified so please take
> > another look at that. Frankly it looks like the original author
> > threw in casts because they didn't want to have to think about which ones
> > actually do anything!
>
> Ok. I will remove the ones mentioned below.
>
> > Few other things to fix up for v5 as well.
>
> I will send the fixes in an hour.
>
> > Jonathan
> >
> >
> > > +#define BME680_NB_CONV_MASK GENMASK(3, 0)
> > > +#define BME680_RUN_GAS_EN_BIT BIT(4)
> >
> > odd looking spacing above.
>
> I don't know why this is showing like that in the diff output, but I
> have checked the code by apllying to my test tree(git am <patch>) and
> there was no such spurious spacing!
You have a tab after the #define in this one instance - in the others it's
all spaces (as it should be)
...
prev parent reply other threads:[~2018-07-21 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 21:31 [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor Himanshu Jha
2018-07-21 15:19 ` Jonathan Cameron
2018-07-21 15:36 ` Himanshu Jha
2018-07-21 15:43 ` Andy Shevchenko
2018-07-21 15:52 ` Himanshu Jha
2018-07-21 16:29 ` Jonathan Cameron
2018-07-21 17:45 ` Daniel Baluta
2018-07-22 22:21 ` Himanshu Jha
2018-07-23 22:16 ` David Frey
2018-07-23 23:02 ` Himanshu Jha
2018-07-21 16:31 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721173131.6be1579f@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=himanshujha199640@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).