From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-iio-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:46778 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728001AbeGVJJn (ORCPT <rfc822;linux-iio@vger.kernel.org>);
        Sun, 22 Jul 2018 05:09:43 -0400
Date: Sun, 22 Jul 2018 09:13:47 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/18] iio: change strncpy+truncation to strlcpy
Message-ID: <20180722091347.1faa81f0@archlinux>
In-Reply-To: <20180716114206.GA20555@nautica>
References: <1531444483-17338-1-git-send-email-asmadeus@codewreck.org>
        <1531445134-19250-1-git-send-email-asmadeus@codewreck.org>
        <20180715113907.3813384d@archlinux>
        <20180716114206.GA20555@nautica>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: linux-iio-owner@vger.kernel.org
List-Id: linux-iio@vger.kernel.org

On Mon, 16 Jul 2018 13:42:06 +0200
Dominique Martinet <asmadeus@codewreck.org> wrote:

> Jonathan Cameron wrote on Sun, Jul 15, 2018:
> > On Fri, 13 Jul 2018 03:25:34 +0200
> > Dominique Martinet <asmadeus@codewreck.org> wrote: =20
> > > Generated by scripts/coccinelle/misc/strncpy_truncation.cocci
> > >=20
> > > Signed-off-by: Dominique Martinet <asmadeus@codewreck.org> =20
> >=20
> > Applied to the togreg branch of iio.git and pushed out as testing
> > for the autobuilders to play with it. =20
>=20
> Thanks!
>=20
> I have been pointed out that strlcpy, unlike strncpy, will read past the
> size given in the input string and thus is Bad=E2=84=A2 if the input stri=
ng is
> not nul terminated.
>=20
> After taking the time to check I believe this should not happen as the
> original name seems to come from a dentry's d_name after proper
> preparation (a buffer is allocated precisely for this purpose), but it
> will not hurt to wait for that version.
>=20
>=20
> The second reason I was waiting is that I intended to check for each
> patch if it is safe to not pad the end of the string with zeroes (to
> avoid e.g. information leaks) and that seems OK as well here after a
> quick check but I wouldn't trust my own eyes this late so I'll let you
> be judge of that if you feel like taking v1 anyway.
>=20
> Otherwise, I'll recheck properly and submit a v2 with strscpy and a
> better commit message after the coccinelle script is taken for inclusion
> and doing a better check but this might take a while longer.
>=20
>=20
> Thanks,

In this particular case I'm fairly sure it is safe so I'll leave it as is.

Thanks,

Jonathan