From: Jonathan Cameron <jic23@kernel.org>
To: Tomas Novotny <tomas.novotny@tbs-biometrics.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Tomas Novotny <tomas@novotny.cz>
Subject: Re: [PATCH v3 2/4] iio: vcnl4000: add VCNL4010 and VCNL4020 device id
Date: Sun, 29 Jul 2018 12:35:35 +0100 [thread overview]
Message-ID: <20180729123535.25fcddc9@archlinux> (raw)
In-Reply-To: <20180725151821.17566-3-tomas.novotny@tbs-biometrics.com>
On Wed, 25 Jul 2018 17:18:19 +0200
Tomas Novotny <tomas.novotny@tbs-biometrics.com> wrote:
> From: Tomas Novotny <tomas@novotny.cz>
>
> The driver already supports VCNL4010/20 devices. The currently supported
> features and detectable product id are the same, so add shared id for
> them.
>
> This is a groundwork to extend the driver by detecting incorrectly
> specified device id.
>
> Signed-off-by: Tomas Novotny <tomas@novotny.cz>
Applied.
Thanks,
Jonathan
> ---
> Changes v2..v3:
> - improve commit message
> - add vcnl4020 device id
>
> drivers/iio/light/vcnl4000.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 32c0b531395f..980eb3b77d5f 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -48,6 +48,7 @@
>
> enum vcnl4000_device_ids {
> VCNL4000,
> + VCNL4010,
> };
>
> struct vcnl4000_data {
> @@ -68,6 +69,8 @@ struct vcnl4000_chip_spec {
>
> static const struct i2c_device_id vcnl4000_id[] = {
> { "vcnl4000", VCNL4000 },
> + { "vcnl4010", VCNL4010 },
> + { "vcnl4020", VCNL4010 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, vcnl4000_id);
> @@ -157,6 +160,12 @@ static const struct vcnl4000_chip_spec vcnl4000_chip_spec_cfg[] = {
> .measure_light = vcnl4000_measure_light,
> .measure_proximity = vcnl4000_measure_proximity,
> },
> + [VCNL4010] = {
> + .prod = "VCNL4010/4020",
> + .init = vcnl4000_init,
> + .measure_light = vcnl4000_measure_light,
> + .measure_proximity = vcnl4000_measure_proximity,
> + },
> };
>
> static const struct iio_chan_spec vcnl4000_channels[] = {
next prev parent reply other threads:[~2018-07-29 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 15:18 [PATCH v3 0/4] iio: vcnl4000: add support for vcnl4200 Tomas Novotny
2018-07-25 15:18 ` [PATCH v3 1/4] iio: vcnl4000: make the driver extendable Tomas Novotny
2018-07-29 11:20 ` Jonathan Cameron
2018-07-25 15:18 ` [PATCH v3 2/4] iio: vcnl4000: add VCNL4010 and VCNL4020 device id Tomas Novotny
2018-07-29 11:35 ` Jonathan Cameron [this message]
2018-07-25 15:18 ` [PATCH v3 3/4] iio: vcnl4000: warn on incorrectly specified " Tomas Novotny
2018-07-29 11:35 ` Jonathan Cameron
2018-07-25 15:18 ` [PATCH v3 4/4] iio: vcnl4000: add support for VCNL4200 Tomas Novotny
2018-07-29 11:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729123535.25fcddc9@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tomas.novotny@tbs-biometrics.com \
--cc=tomas@novotny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).