From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:42002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbeHSTON (ORCPT ); Sun, 19 Aug 2018 15:14:13 -0400 Date: Sun, 19 Aug 2018 17:02:15 +0100 From: Jonathan Cameron To: Himanshu Jha Cc: David Frey , linux-iio@vger.kernel.org Subject: Re: [PATCH v3 3/7] iio: chemical: bme680: indent #defines consistently Message-ID: <20180819170215.35a6b1de@archlinux> In-Reply-To: <20180818110725.GD24920@himanshu-Vostro-3559> References: <20180817190319.13119-1-dpfrey@gmail.com> <20180817190319.13119-4-dpfrey@gmail.com> <20180818110725.GD24920@himanshu-Vostro-3559> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Sat, 18 Aug 2018 16:37:25 +0530 Himanshu Jha wrote: > On Fri, Aug 17, 2018 at 12:03:15PM -0700, David Frey wrote: > > Signed-off-by: David Frey > > Reviewed-by: Himanshu Jha > Tested-by: Himanshu Jha > > Also, 0-day tested with build success! > > Thanks > > Applied, There is one more suspicious bit of indenting in here #define BME680_REG_CTRL_GAS_1 0x71 #define BME680_RUN_GAS_MASK BIT(4) #define BME680_NB_CONV_MASK GENMASK(3, 0) #define BME680_RUN_GAS_EN_BIT BIT(4) #define BME680_NB_CONV_0_VAL 0 I think RUN_GAS_EN_BIT should be one level lower? Thanks, Jonathan