From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: David Frey <dpfrey@gmail.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 7/7] iio: chemical: bme680: simplify oversampling handling
Date: Sun, 19 Aug 2018 17:14:22 +0100 [thread overview]
Message-ID: <20180819171422.6d45a5b2@archlinux> (raw)
In-Reply-To: <20180818111750.GH24920@himanshu-Vostro-3559>
On Sat, 18 Aug 2018 16:47:50 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:
> On Fri, Aug 17, 2018 at 12:03:19PM -0700, David Frey wrote:
> > Temperature, pressure and humidity all expose and oversampling setting
> > that works in the same way. Provide common handling for the
> > oversampling sysfs attributes.
> >
> > Signed-off-by: David Frey <dpfrey@gmail.com>
>
> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>
> Tested-by: Himanshu Jha <himanshujha199640@gmail.com>
>
> Also, 0-day tested with build success!
>
> Thanks
>
> With this I don't think my patch:
> https://lore.kernel.org/lkml/20180811102636.6171-1-himanshujha199640@gmail.com/
> is useful any more since bme680_is_valid_oversampling()
> does the work pehaps.
I don't think it does unfortunately as it doesn't check val2 at all.
So we need a new version of your patch unless I'm missing something.
>
> The best part of this patch is supplying direct values and removes
> the amiguity around ilog2(), especially at probe, when supplying
> default values.
>
> Thanks David for the series.
Indeed. Some nice tidying up. Thanks,
Jonathan
>
prev parent reply other threads:[~2018-08-19 19:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 19:03 [PATCH v3 0/7] bme680 cleanup David Frey
2018-08-17 19:03 ` [PATCH v3 1/7] iio: chemical: bme680: use clamp macro David Frey
2018-08-18 11:03 ` Himanshu Jha
2018-08-19 15:47 ` Jonathan Cameron
2018-08-20 17:18 ` David Frey
2018-08-20 17:55 ` Himanshu Jha
2018-08-20 17:58 ` Jonathan Cameron
2018-08-17 19:03 ` [PATCH v3 2/7] iio: chemical: bme680: cleanup bme680_read_calib formatting David Frey
2018-08-18 11:06 ` Himanshu Jha
2018-08-19 15:54 ` Jonathan Cameron
2018-08-19 17:18 ` Himanshu Jha
2018-08-20 19:24 ` David Frey
2018-08-21 18:46 ` Himanshu Jha
2018-08-17 19:03 ` [PATCH v3 3/7] iio: chemical: bme680: indent #defines consistently David Frey
2018-08-18 11:07 ` Himanshu Jha
2018-08-19 16:02 ` Jonathan Cameron
2018-08-19 17:28 ` Himanshu Jha
2018-08-19 19:14 ` Jonathan Cameron
2018-08-20 15:37 ` Himanshu Jha
2018-08-20 17:39 ` [PATCH] iio: chemical: bme680: Remove field value defines David Frey
2018-08-22 10:44 ` Himanshu Jha
2018-08-25 8:14 ` Jonathan Cameron
2018-08-17 19:03 ` [PATCH v3 4/7] iio: chemical: bme680: change MSK->MASK in #defines David Frey
2018-08-18 11:09 ` Himanshu Jha
2018-08-19 16:05 ` Jonathan Cameron
2018-08-17 19:03 ` [PATCH v3 5/7] iio: chemical: bme680: use GENMASK macro David Frey
2018-08-18 11:09 ` Himanshu Jha
2018-08-19 16:07 ` Jonathan Cameron
2018-08-17 19:03 ` [PATCH v3 6/7] iio: chemical: bme680: use FIELD_GET macro David Frey
2018-08-18 11:10 ` Himanshu Jha
2018-08-19 16:08 ` Jonathan Cameron
2018-08-17 19:03 ` [PATCH v3 7/7] iio: chemical: bme680: simplify oversampling handling David Frey
2018-08-18 11:17 ` Himanshu Jha
2018-08-19 16:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819171422.6d45a5b2@archlinux \
--to=jic23@kernel.org \
--cc=dpfrey@gmail.com \
--cc=himanshujha199640@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).