From: Jonathan Cameron <jic23@kernel.org>
To: Tomasz Duszynski <tduszyns@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: pressure: ms5611: remove deprecated compatible strings
Date: Sun, 19 Aug 2018 17:16:13 +0100 [thread overview]
Message-ID: <20180819171613.0f74335c@archlinux> (raw)
In-Reply-To: <20180816184915.32138-1-tduszyns@gmail.com>
On Thu, 16 Aug 2018 20:49:15 +0200
Tomasz Duszynski <tduszyns@gmail.com> wrote:
> Compatible strings tend to follow manufacturer,model format.
> In case one wants to do a matching with manufacturer stripped
> off he can still do so since SPI/I2C core will try id_table
> based matching anyway.
>
> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/pressure/ms5611_i2c.c | 2 --
> drivers/iio/pressure/ms5611_spi.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/iio/pressure/ms5611_i2c.c b/drivers/iio/pressure/ms5611_i2c.c
> index 55fb5fc0b6ea..0469c8ae1134 100644
> --- a/drivers/iio/pressure/ms5611_i2c.c
> +++ b/drivers/iio/pressure/ms5611_i2c.c
> @@ -117,9 +117,7 @@ static int ms5611_i2c_remove(struct i2c_client *client)
> #if defined(CONFIG_OF)
> static const struct of_device_id ms5611_i2c_matches[] = {
> { .compatible = "meas,ms5611" },
> - { .compatible = "ms5611" },
> { .compatible = "meas,ms5607" },
> - { .compatible = "ms5607" },
> { }
> };
> MODULE_DEVICE_TABLE(of, ms5611_i2c_matches);
> diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
> index 932e05001e1a..cd11d022208e 100644
> --- a/drivers/iio/pressure/ms5611_spi.c
> +++ b/drivers/iio/pressure/ms5611_spi.c
> @@ -119,9 +119,7 @@ static int ms5611_spi_remove(struct spi_device *spi)
> #if defined(CONFIG_OF)
> static const struct of_device_id ms5611_spi_matches[] = {
> { .compatible = "meas,ms5611" },
> - { .compatible = "ms5611" },
> { .compatible = "meas,ms5607" },
> - { .compatible = "ms5607" },
> { }
> };
> MODULE_DEVICE_TABLE(of, ms5611_spi_matches);
prev parent reply other threads:[~2018-08-19 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 18:49 [PATCH] iio: pressure: ms5611: remove deprecated compatible strings Tomasz Duszynski
2018-08-19 16:16 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819171613.0f74335c@archlinux \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).