From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: dpfrey@gmail.com, daniel.baluta@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: bme680: Add check for val2 in the write_raw function
Date: Sun, 19 Aug 2018 20:08:20 +0100 [thread overview]
Message-ID: <20180819200820.3ad2252a@archlinux> (raw)
In-Reply-To: <20180819171014.GA13175@himanshu-Vostro-3559>
On Sun, 19 Aug 2018 22:40:14 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:
> On Sun, Aug 19, 2018 at 05:25:14PM +0100, Jonathan Cameron wrote:
> > On Sat, 11 Aug 2018 15:56:36 +0530
> > Himanshu Jha <himanshujha199640@gmail.com> wrote:
> >
> > > val2 is responsible for the floating part of the number to be
> > > written to the device. We don't need the floating part
> > > while writing the oversampling ratio for BME680 since the
> > > available oversampling ratios are pure natural numbers.
> > >
> > > So, add a sanity check to make sure val2 is 0.
> > >
> > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> >
> > As discussed in David's patch series v3, I think this is still relevant
> > but now needs an update to cover the new code.
>
> I already had informed David to reabse his series on top of my patch
> and he rebased this patch series.
>
> So, it should apply cleanly without any further effort.
>
> If it doesn't, then ping me.
Meh, was only some trivial fuzz. I thought things had changed more than that
as hadn't noticed you just applied it at the top of write_raw as all the
things that can be written in this driver are integers.
Anyhow, applied now. Thanks,
Jonathan
>
prev parent reply other threads:[~2018-08-19 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 10:26 [PATCH] iio: chemical: bme680: Add check for val2 in the write_raw function Himanshu Jha
2018-08-19 16:25 ` Jonathan Cameron
2018-08-19 17:10 ` Himanshu Jha
2018-08-19 19:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819200820.3ad2252a@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=dpfrey@gmail.com \
--cc=himanshujha199640@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).